script_stop: true mess up cat command

[uchar]

Describe the bug

When I use script_stop: true the output of the cat command becomes

    {
              "RESTORE_BACKUP": "$RESTORE_BACKUP",
              "FTP_HOST": "$FTP_HOST",
              DRONE_SSH_PREV_COMMAND_EXIT_CODE=0 ; if [ 0 -ne 0 ]; then exit 0; fi;
             {
              DRONE_SSH_PREV_COMMAND_EXIT_CODE=0 ; if [ 0 -ne 0 ]; then exit 0; fi;

Yaml Config

      - name: Clone project and run docker
        uses: appleboy/ssh-action@master
        env:
          FTP_HOST: ${{ secrets.FTP_HOST }}
          RESTORE_BACKUP: ${{ github.event.inputs.restoreBackup }}
        with:
          command_timeout: 60m
          script_stop: true
          host: ${{ secrets.SSH_HOST }}
          username: ${{ secrets.SSH_USER }}
          key: ${{ secrets.SSH_PRIVATE_KEY }}
          port: ${{ secrets.SSH_PORT }}
          envs: FTP_HOST,RESTORE_BACKUP
          script: |
            cat <<EOF > ./inputsData/deployEnvs.json
            {
              "RESTORE_BACKUP": "$RESTORE_BACKUP",
              "FTP_HOST": "$FTP_HOST",
            }
            EOF

it works fine without script_stop: true

[ArtemGoutsoul]

bumped into the same issue when using ssh-action to update nginx configs remotely

this bug makes HEREDOC unusable in this context :(

as a workaround I had to convert the HEREDOC into one-liner which greatly reduced the readability of the workflow

[georgique]

I can confirm that if statements are not working correctly with script_stop=true.

Script:

echo "TMP TESTING IF"
if [[ "2" == "1" ]]; then
  echo "True"
else
  echo "False"
fi

Output:

out: TMP TESTING IF
2024/09/24 21:19:30 Process exited with status 1

Script:

echo "TMP TESTING IF"
if [[ "1" == "1" ]]; then
  echo "True"
else
  echo "False"
fi

Output:

out: TMP TESTING IF
out: True
2024/09/24 21:20:40 Process exited with status 1

[appleboy]

I will disable the script_stop flag on the next version.

[georgique]

@appleboy How is that a fix? It was a very needed functionality

[uchar]

I think this issue should remains open until a proper solution found

[appleboy]

@georgique @uchar See the PR for the sample code:

#355

result: https://github.com/appleboy/ssh-action/actions/runs/12175794110/job/33960230162

      - id: stdout01
        name: ssh command with stdout 01
        uses: appleboy/ssh-action@master
        with:
          host: ${{ env.REMOTE_HOST }}
          username: linuxserver.io
          password: password
          port: 2222
          capture_stdout: true
          script: |
            #!/usr/bin/env bash
            set -e
            echo "TMP TESTING IF"
            if [[ "2" == "1" ]]; then
              echo "True"
            else
              echo "False"
            fi

      - name: check stdout 01
        run: |
          echo "stdout: ${{ steps.stdout01.outputs.stdout }}"
          if echo "${{ steps.stdout01.outputs.stdout }}" | grep -q "True"; then
            echo "Output contains 'True'"
            exit 1
          fi
          if echo "${{ steps.stdout01.outputs.stdout }}" | grep -q "False"; then
            echo "Output contains 'False'"
          fi

      - id: stdout02
        name: ssh command with stdout 01
        uses: appleboy/ssh-action@master
        with:
          host: ${{ env.REMOTE_HOST }}
          username: linuxserver.io
          password: password
          port: 2222
          capture_stdout: true
          script: |
            #!/usr/bin/env bash
            set -e
            echo "TMP TESTING IF"
            if [[ "1" == "1" ]]; then
              echo "True"
            else
              echo "False"
            fi

      - name: check stdout 02
        run: |
          echo "stdout: ${{ steps.stdout02.outputs.stdout }}"
          if echo "${{ steps.stdout02.outputs.stdout }}" | grep -q "False"; then
            echo "Output contains 'False'"
            exit 1
          fi
          if echo "${{ steps.stdout02.outputs.stdout }}" | grep -q "True"; then
            echo "Output contains 'True'"
          fi