Bad filename for tests inherited from abstract class

[lmartelli]

If a test class inherits test methods from a base class, the filenames for received/approved documents use the name of the base class.

For instance :

class MyTest {
	class BaseTest {
		@Test
		void sharedTest() {
			Approvals.verify("result");
		}
	}

	@Nested
	class NestedTest extends BaseTest {
	}
}

will generate MyTest.BaseTest.sharedTest.received.txt. It would be better to have MyTest.NestedTest.sharedTest.received.txt to avoid conflicts if when you have multiple tests classes that inherit from BaseTest.

[isidore]

I'm not sure I understand the purpose of have a BaseTest with unit tests that is extended.
Helping me understand this would probably yield a better solution.

However, as way of explanation, the Reflection API is detecting the class where the method is declared.

Probably it would be best to pair on this problem. Please reach out with an email and we will setup a zoom call.

[lmartelli]

I'm not sure I understand the purpose of have a BaseTest with unit tests that is extended. Helping me understand this would probably yield a better solution.

I was testing email templates in several languages. The tests checked that the produced HTML contains correct data or links, whatever the language. My 1st approach was to create an abstract test class with all the tests, and one concrete non abstract test class per language. In the end, I introduced an enum for the supported languages and used @ParameterizedTest, which is a better approach I believe.