Skip to content

Commit 68cea4a

Browse files
committed
- r extract function setup_approvals
1 parent e911e0d commit 68cea4a

2 files changed

Lines changed: 25 additions & 34 deletions

File tree

setup/setup.approval_utilities.py

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,18 @@
11
import sys
22
from pathlib import Path
3-
from typing import Any
43

5-
from setuptools import find_packages, setup
4+
from setuptools import find_packages
65

76
_SCRIPT_DIR = Path(__file__).parent.resolve()
87

98
sys.path.insert(0, str(_SCRIPT_DIR / "setup"))
10-
from setup_utils import ( # pylint: disable=wrong-import-position
11-
PYTHON_VERSION_CLASSIFIERS,
12-
get_version,
13-
)
9+
from setup_utils import setup_approvals # pylint: disable=wrong-import-position
1410

15-
setup(
11+
setup_approvals(
1612
name="approval_utilities",
17-
version=get_version(),
1813
description="Utilities for your production code that work well with approvaltests",
19-
author="ApprovalTests Contributors",
20-
author_email="llewellyn.falco@gmail.com",
21-
url="https://github.com/approvals/ApprovalTests.Python",
22-
python_requires=">=3.10",
2314
packages=find_packages(include=["approval_utilities*"]),
24-
package_data={},
2515
install_requires=[],
2616
# long_description=(get_parent_directory() / "README.md").read_text(),
2717
# long_description_content_type="text/markdown",
28-
license="Apache-2.0",
29-
classifiers=[
30-
"Development Status :: 4 - Beta",
31-
"Intended Audience :: Developers",
32-
"Operating System :: POSIX",
33-
"Operating System :: Microsoft :: Windows",
34-
"Operating System :: MacOS :: MacOS X",
35-
*PYTHON_VERSION_CLASSIFIERS,
36-
"Topic :: Software Development :: Libraries",
37-
"Topic :: Utilities",
38-
],
3918
)

setup/setup_utils.py

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import sys
22
from pathlib import Path
3+
from typing import Any
34

45
from setuptools import find_packages, setup
56

@@ -39,14 +40,9 @@ def setup_approvaltests(
3940
build_dir = _SCRIPT_DIR / "build"
4041
build_dir.mkdir(exist_ok=True)
4142

42-
setup(
43+
setup_approvals(
4344
name=package_name,
44-
version=get_version(),
4545
description=package_description,
46-
author="ApprovalTests Contributors",
47-
author_email="llewellyn.falco@gmail.com",
48-
url="https://github.com/approvals/ApprovalTests.Python",
49-
python_requires=">=3.10",
5046
packages=find_packages(include=["approvaltests*"]),
5147
package_data={"approvaltests": ["reporters/reporters.json"]},
5248
entry_points={
@@ -55,10 +51,26 @@ def setup_approvaltests(
5551
],
5652
},
5753
install_requires=required,
58-
extras_require=extra_requires,
54+
extra_requires=extra_requires,
5955
long_description=(_SCRIPT_DIR.parent / "README.md").read_text(),
6056
long_description_content_type="text/markdown",
57+
additional_classifiers=[
58+
"Topic :: Software Development :: Testing",
59+
"Topic :: Utilities",
60+
],
61+
)
62+
63+
def setup_approvals(
64+
additional_classifiers: list[str] = [],
65+
**kwargs: Any,
66+
) -> None:
67+
setup(
68+
version=get_version(),
6169
license="Apache-2.0",
70+
author="ApprovalTests Contributors",
71+
author_email="llewellyn.falco@gmail.com",
72+
url="https://github.com/approvals/ApprovalTests.Python",
73+
python_requires=">=3.10",
6274
classifiers=[
6375
"Development Status :: 4 - Beta",
6476
"Intended Audience :: Developers",
@@ -67,7 +79,7 @@ def setup_approvaltests(
6779
"Operating System :: MacOS :: MacOS X",
6880
*PYTHON_VERSION_CLASSIFIERS,
6981
"Topic :: Software Development :: Libraries",
70-
"Topic :: Software Development :: Testing",
71-
"Topic :: Utilities",
82+
*additional_classifiers,
7283
],
73-
)
84+
**kwargs,
85+
)

0 commit comments

Comments
 (0)