Skip to content

Commit ffd2db3

Browse files
JayBazuziisidorereyr-dev
committed
- F Remove support for Python 3.8 and 3.9
`mise install` rejects Python 3.8 on GitHub actions due to missing attestation. Rather than disabling attestation, we are removing older Python versions that are past end-of-life. Co-Authored-By: Llewellyn Falco <llewellyn.falco@gmail.com> Co-Authored-By: reyr-dev <236299828+reyr-dev@users.noreply.github.com>
1 parent 3df2bdd commit ffd2db3

12 files changed

Lines changed: 10 additions & 20 deletions

.github/workflows/test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
python-version:
13-
- "3.8"
14-
- "3.9"
1513
- "3.10"
1614
- "3.11"
1715
- "3.12"

.github/workflows/test_current_release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ jobs:
1616
fail-fast: true
1717
matrix:
1818
python-version:
19-
- "3.8"
20-
- "3.9"
2119
- "3.10"
2220
- "3.11"
2321
- "3.12"

.github/workflows/test_min.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
python-version:
13-
- "3.8"
14-
- "3.9"
1513
- "3.10"
1614
- "3.11"
1715
- "3.12"

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ repos:
1414
# - id: end-of-file-fixer
1515
# - id: flake8
1616
# additional_dependencies: ["flake8-bugbear == 19.3.0"]
17-
# language_version: python3.8
17+
# language_version: python3.10
1818
# - id: trailing-whitespace
1919

2020
# - repo: https://github.com/asottile/pyupgrade

.python-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.8
1+
3.10

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ If there is documentation you wish existed, please add a `page request` to [this
270270

271271
### Dependencies
272272

273-
ApprovalTests is tested on the following Python versions: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.<!-- singleLineInclude: tests/approved_files/test_workflow_matrix.test_workflow_matrix_python_versions.approved.txt -->
273+
ApprovalTests is tested on the following Python versions: 3.10, 3.11, 3.12, 3.13, 3.14.<!-- singleLineInclude: tests/approved_files/test_workflow_matrix.test_workflow_matrix_python_versions.approved.txt -->
274274

275275
For older versions of Python, either use an older version of ApprovalTests or use [TextTest](https://texttest.org/).
276276

@@ -321,7 +321,7 @@ Pull requests are welcomed, particularly those accompanied by automated tests.
321321
To run the self-tests:
322322
`./build_and_test.sh`
323323

324-
This will run the self-tests on several python versions. We support python 3.8 and above.
324+
This will run the self-tests on several python versions. We support python 3.10 and above.
325325

326326
All pull requests will be pre-checked using GitHub actions to execute all these tests. You can see the [results of test
327327
runs here](https://github.com/approvals/ApprovalTests.Python/actions).

install.windows.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ iwr -useb https://raw.githubusercontent.com/JayBazuzi/machine-setup/main/windows
1111
iwr -useb cin.st | iex
1212
choco feature enable --name=allowGlobalConfirmation
1313
choco install beyondcompare
14-
choco install python --version=3.8
14+
choco install python --version=3.10
1515
choco install pip
1616
choco install pycharm
1717
choco install ditto

internal_documentation/micro_features/build_system_migration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ Same Source: approvaltests (full) ═══ same code ═══ approval
172172

173173
**test.yml** - Main CI testing
174174
- Runs on: push, PR, manual
175-
- Matrix: Python 3.8-3.14 × 3 OS (macOS, Ubuntu, Windows)
175+
- Matrix: Python 3.10-3.14 × 3 OS (macOS, Ubuntu, Windows)
176176
- Uses: `./build_and_test.sh` (which uses `setup.py install`)
177177

178178
**test_min.yml** - Minimal dependency testing

ruff.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
target-version = "py38"
1+
target-version = "py310"
22

33
[format]
44
line-ending = "lf"
@@ -28,6 +28,4 @@ ignore = [
2828
"TC006", # Add quotes to type expression in `typing.cast()`
2929
"TD006", # Invalid TODO capitalization: `...` should be `TODO`
3030

31-
# needed for Python 3.8 compatibility
32-
"UP035", # Import from `collections.abc` instead
3331
]

setup/setup.approval_utilities.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
author="ApprovalTests Contributors",
2121
author_email="llewellyn.falco@gmail.com",
2222
url="https://github.com/approvals/ApprovalTests.Python",
23-
python_requires=">=3.8",
23+
python_requires=">=3.10",
2424
packages=find_packages(include=["approval_utilities*"]),
2525
package_data={},
2626
install_requires=[],

0 commit comments

Comments
 (0)