Skip to content

reporter_that_creates_an_approval_script doesn't work on Windows #57

Open
@JayBazuzi

Description

@JayBazuzi
  • It writes a .sh file, should be .cmd
  • It writes Unix-style newlines (\n), should be Windows-style (\r\n)
  • It writes a Bash shebang header (#!/bin/bash), should not

Also, neither Windows nor Unix-like scripts have any error handling; maybe that is OK.

Also, tests!

Suggestion: separate out a data structure that describes what needs to be done from a "formatter" that writes it as a script.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions