Skip to content

Commit 1c13ee2

Browse files
Fix dnsNames in ace cert for acme (#1222)
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
1 parent 21e155f commit 1c13ee2

6 files changed

Lines changed: 32 additions & 26 deletions

File tree

charts/ace-installer-certified-crds/README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
# ACE Installer
1+
# ace-installer-certified-crds
22

3-
[ACE Installer](https://github.com/appscode-cloud/installer) - ACE Installer
3+
[ace-installer-certified-crds](https://github.com/appscode-cloud/installer) - ACE Installer
44

55
## TL;DR;
66

77
```bash
88
$ helm repo add appscode https://charts.appscode.com/stable/
99
$ helm repo update
10-
$ helm search repo appscode/ace-installer --version=v2026.3.30
11-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
10+
$ helm search repo appscode/ace-installer-certified-crds --version=2026.3.30
11+
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30
1212
```
1313

1414
## Introduction
@@ -21,10 +21,10 @@ This chart deploys charts for ACE on a [Kubernetes](http://kubernetes.io) cluste
2121

2222
## Installing the Chart
2323

24-
To install/upgrade the chart with the release name `ace-installer`:
24+
To install/upgrade the chart with the release name `ace-installer-certified-crds`:
2525

2626
```bash
27-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
27+
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30
2828
```
2929

3030
The command deploys charts for ACE on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
@@ -33,17 +33,17 @@ The command deploys charts for ACE on the Kubernetes cluster in the default conf
3333
3434
## Uninstalling the Chart
3535

36-
To uninstall the `ace-installer`:
36+
To uninstall the `ace-installer-certified-crds`:
3737

3838
```bash
39-
$ helm uninstall ace-installer -n kubeops
39+
$ helm uninstall ace-installer-certified-crds -n kubeops
4040
```
4141

4242
The command removes all the Kubernetes components associated with the chart and deletes the release.
4343

4444
## Configuration
4545

46-
The following table lists the configurable parameters of the `ace-installer` chart and their default values.
46+
The following table lists the configurable parameters of the `ace-installer-certified-crds` chart and their default values.
4747

4848
| Parameter | Description | Default |
4949
|-------------------------------------------------------|----------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
@@ -149,12 +149,12 @@ The following table lists the configurable parameters of the `ace-installer` cha
149149
Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade -i`. For example:
150150

151151
```bash
152-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --set image.proxies.appscode=r.appscode.com
152+
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30 --set image.proxies.appscode=r.appscode.com
153153
```
154154

155155
Alternatively, a YAML file that specifies the values for the parameters can be provided while
156156
installing the chart. For example:
157157

158158
```bash
159-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --values values.yaml
159+
$ helm upgrade -i ace-installer-certified-crds appscode/ace-installer-certified-crds -n kubeops --create-namespace --version=2026.3.30 --values values.yaml
160160
```

charts/ace-installer-certified/README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
# ACE Installer
1+
# ace-installer-certified
22

3-
[ACE Installer](https://github.com/appscode-cloud/installer) - ACE Installer
3+
[ace-installer-certified](https://github.com/appscode-cloud/installer) - ACE Installer
44

55
## TL;DR;
66

77
```bash
88
$ helm repo add appscode https://charts.appscode.com/stable/
99
$ helm repo update
10-
$ helm search repo appscode/ace-installer --version=v2026.3.30
11-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
10+
$ helm search repo appscode/ace-installer-certified --version=2026.3.30
11+
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30
1212
```
1313

1414
## Introduction
@@ -21,10 +21,10 @@ This chart deploys charts for ACE on a [Kubernetes](http://kubernetes.io) cluste
2121

2222
## Installing the Chart
2323

24-
To install/upgrade the chart with the release name `ace-installer`:
24+
To install/upgrade the chart with the release name `ace-installer-certified`:
2525

2626
```bash
27-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30
27+
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30
2828
```
2929

3030
The command deploys charts for ACE on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
@@ -33,17 +33,17 @@ The command deploys charts for ACE on the Kubernetes cluster in the default conf
3333
3434
## Uninstalling the Chart
3535

36-
To uninstall the `ace-installer`:
36+
To uninstall the `ace-installer-certified`:
3737

3838
```bash
39-
$ helm uninstall ace-installer -n kubeops
39+
$ helm uninstall ace-installer-certified -n kubeops
4040
```
4141

4242
The command removes all the Kubernetes components associated with the chart and deletes the release.
4343

4444
## Configuration
4545

46-
The following table lists the configurable parameters of the `ace-installer` chart and their default values.
46+
The following table lists the configurable parameters of the `ace-installer-certified` chart and their default values.
4747

4848
| Parameter | Description | Default |
4949
|-------------------------------------------------------|----------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
@@ -149,12 +149,12 @@ The following table lists the configurable parameters of the `ace-installer` cha
149149
Specify each parameter using the `--set key=value[,key=value]` argument to `helm upgrade -i`. For example:
150150

151151
```bash
152-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --set image.proxies.appscode=r.appscode.com
152+
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30 --set image.proxies.appscode=r.appscode.com
153153
```
154154

155155
Alternatively, a YAML file that specifies the values for the parameters can be provided while
156156
installing the chart. For example:
157157

158158
```bash
159-
$ helm upgrade -i ace-installer appscode/ace-installer -n kubeops --create-namespace --version=v2026.3.30 --values values.yaml
159+
$ helm upgrade -i ace-installer-certified appscode/ace-installer-certified -n kubeops --create-namespace --version=2026.3.30 --values values.yaml
160160
```

charts/ace/templates/gateway/route-nats.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,11 @@ spec:
5454
- group: ""
5555
kind: Secret
5656
name: {{ include "ace.fullname" . }}-cert
57+
{{ if eq (index .Values "global" "platform" "hostType") "ip" }}
5758
hostname: {{ include "ace.fullname" . }}-nats
59+
{{- else }}
60+
hostname: {{ .Values.global.platform.host }}
61+
{{- end }}
5862

5963
---
6064
apiVersion: gateway.networking.k8s.io/v1alpha2

charts/ace/templates/ingress/certificate.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,14 @@ spec:
1717
kind: Issuer
1818
name: {{ include "ace.fullname" . }}
1919
dnsNames:
20+
{{ if eq (index .Values "global" "platform" "hostType") "ip" }}
2021
- {{ include "ace.fullname" . }}-nats
2122
- {{ include "ace.fullname" . }}-nats.{{ .Release.Namespace }}.svc
2223
- {{ include "ace.fullname" . }}-nats.{{ .Release.Namespace }}.svc.cluster.local
2324
- {{ include "ace.fullname" . }}-s3proxy
2425
- {{ include "ace.fullname" . }}-s3proxy.{{ .Release.Namespace }}.svc
2526
- {{ include "ace.fullname" . }}-s3proxy.{{ .Release.Namespace }}.svc.cluster.local
27+
{{- end }}
2628
{{- if eq .Values.global.platform.hostType "domain" }}
2729
- "{{ .Values.global.platform.host }}"
2830
{{- if and .Values.nats.enabled .Values.nats.nats.externalAccess }}

charts/ace/templates/ingress/issuer.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ spec:
7575
parentRefs:
7676
- group: gateway.networking.k8s.io
7777
kind: Gateway
78-
name: {{ include "ace.fullname" . }}
79-
namespace: {{ .Release.Namespace }}
80-
sectionName: api
78+
name: {{ include "ace.fullname" . }}-gw-seed-backend
79+
namespace: {{ .Release.Namespace }}-gw
80+
sectionName: http
8181
{{- else }}
8282
ingress:
8383
ingressClassName: {{ index .Values "ingress-nginx" "controller" "ingressClassResource" "name" }}

charts/s3proxy/templates/httproute.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ spec:
5959
- group: ""
6060
kind: Secret
6161
name: {{ include "ace.fullname" . }}-cert
62-
hostname: {{ include "ace.fullname" . }}-s3proxy
62+
hostname: {{ index .Values.gateway.hosts 0 }}
6363
{{- end }}
6464

6565
---

0 commit comments

Comments
 (0)