Test against the latest Phoenix versions on CI (#111)

In PR #93, it looks like we omitted the Phoenix versions, so it now
always tested against version 1.4. This adds back testing against
different versions of Phoenix.

Fix issues I encountered when adding these different versions.

Author: tombruijn

.github/workflows/ci.yml

@@ -26,6 +26,8 @@ jobs:
 
   lint_format:
     runs-on: ubuntu-latest
+    env:
+      PHOENIX_VERSION: "~> 1.7.0"
     steps:
       - name: Set up Erlang and Elixir
         uses: erlef/setup-beam@v1
@@ -39,6 +41,8 @@ jobs:
 
   lint_credo:
     runs-on: ubuntu-latest
+    env:
+      PHOENIX_VERSION: "~> 1.7.0"
     steps:
       - name: Set up Erlang and Elixir
         uses: erlef/setup-beam@v1
@@ -54,6 +58,8 @@ jobs:
 
   lint_compile:
     runs-on: ubuntu-latest
+    env:
+      PHOENIX_VERSION: "~> 1.7.0"
     steps:
       - name: Set up Erlang and Elixir
         uses: erlef/setup-beam@v1
@@ -69,6 +75,8 @@ jobs:
 
   lint_dialyzer:
     runs-on: ubuntu-latest
+    env:
+      PHOENIX_VERSION: "~> 1.7.0"
     steps:
       - name: Set up Erlang and Elixir
         uses: erlef/setup-beam@v1
@@ -101,23 +109,34 @@ jobs:
           - 27.x
           - 26.x
           - 25.x
+        phoenix:
+          - "~> 1.6.0"
+          - "~> 1.7.0"
         include:
           - elixir: main
             otp: 27.x
+            phoenix: "~> 1.7.0"
           - elixir: latest
             otp: 27.x
+            phoenix: "~> 1.7.0"
           - elixir: 1.16.x
             otp: 26.x
+            phoenix: "~> 1.7.0"
           - elixir: 1.15.x
             otp: 26.x
+            phoenix: "~> 1.7.0"
           - elixir: 1.14.x
             otp: 25.x
+            phoenix: "~> 1.6.0"
           - elixir: 1.13.x
             otp: 24.x
+            phoenix: "~> 1.6.0"
           - elixir: 1.12.x
             otp: 24.x
+            phoenix: "~> 1.6.0"
           - elixir: 1.11.x
             otp: 24.x
+            phoenix: "~> 1.6.0"
 
     steps:
       - name: Set up Erlang and Elixir
@@ -129,5 +148,9 @@ jobs:
         uses: actions/checkout@v4
       - name: Get dependencies
         run: mix deps.get
+        env:
+          PHOENIX_VERSION: ${{matrix.phoenix}}
       - name: Run tests
         run: mix test
+        env:
+          PHOENIX_VERSION: ${{matrix.phoenix}}

lib/appsignal_phoenix/view.ex

@@ -1,4 +1,6 @@
 defmodule Appsignal.Phoenix.View do
+  require Logger
+
   @moduledoc """
   AppSignal.Phoenix.View instruments template rendering.
 
@@ -40,6 +42,8 @@ defmodule Appsignal.Phoenix.View do
 
   defmacro __before_compile__(_env) do
     quote do
+      require Logger
+
       if Module.defines?(__MODULE__, {:__templates__, 0}) &&
            Module.defines?(__MODULE__, {:render, 2}) do
         @span Application.compile_env(:appsignal, :appsignal_span, Appsignal.Span)

mix.exs

@@ -51,10 +51,19 @@ defmodule Appsignal.Phoenix.MixProject do
         _ -> "~> 1.7"
       end
 
+    phoenix_version =
+      case {System.get_env("CI"), System.get_env("PHOENIX_VERSION")} do
+        {"true", nil} ->
+          raise "PHOENIX_VERSION environment variable must be set on CI"
+
+        {_, version} ->
+          version || "~> 1.7"
+      end
+
     [
       {:appsignal, ">= 2.15.0 and < 3.0.0"},
       {:appsignal_plug, ">= 2.1.0 and < 3.0.0"},
-      {:phoenix, System.get_env("PHOENIX_VERSION", "~> 1.4")},
+      {:phoenix, phoenix_version},
       {:phoenix_html, "~> 2.11 or ~> 3.0 or ~> 4.0", optional: true},
       {:phoenix_live_view, phoenix_live_view_version, optional: true},
       {:ex_doc, "~> 0.21", only: :dev, runtime: false},