Skip to content

Commit 28d3b5e

Browse files
authored
Merge pull request #259 from appsignal/set-error-alert-this-error
Set `alert_this_error` when setting errors
2 parents 7e9d2b7 + 9d12d9b commit 28d3b5e

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
bump: patch
3+
type: fix
4+
---
5+
6+
Fix an issue where errors set with the `set_error` helper would not always be reported as errors in AppSignal when using collector mode.

src/appsignal/tracing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def set_root_name(root_name: str, span: Span | None = None) -> None:
9191
def set_error(error: Exception, span: Span | None = None) -> None:
9292
span = span or trace.get_current_span()
9393
span.set_status(Status(StatusCode.ERROR))
94-
span.record_exception(error)
94+
span.record_exception(error, attributes={"appsignal.alert_this_error": True})
9595

9696

9797
def send_error(error: Exception) -> None:

0 commit comments

Comments
 (0)