Skip to content

Commit 6182e02

Browse files
authored
Merge pull request #1545 from appsignal/prepare-minor-release
Add config options to control instrumentation
2 parents c6b8ed2 + 5aa8bf0 commit 6182e02

33 files changed

Lines changed: 299 additions & 77 deletions

β€Ž.changesets/add-delayed-job-enqueue-instrumentation.mdβ€Ž

Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
bump: minor
3+
type: add
4+
---
5+
6+
Add config options to turn individual integrations off. Set
7+
`instrument_sidekiq`, `instrument_shoryuken`, `instrument_que`,
8+
`instrument_resque`, `instrument_delayed_job`, `instrument_active_job`,
9+
`instrument_excon` or `instrument_mongo` to `false` to disable that
10+
integration entirely. This turns off both the instrumentation of the jobs or
11+
requests and the enqueue instrumentation for that integration. They all
12+
default to `true`. Each can also be set through its environment variable, such
13+
as `APPSIGNAL_INSTRUMENT_SIDEKIQ`.

β€Ž.changesets/add-shoryuken-enqueue-instrumentation.mdβ€Ž

Lines changed: 0 additions & 8 deletions
This file was deleted.

β€Ž.changesets/emit-mongodb-body-as-json-string.mdβ€Ž

Lines changed: 0 additions & 6 deletions
This file was deleted.

β€Ž.changesets/instrument-active-job-enqueues.mdβ€Ž

Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
---
2+
bump: minor
3+
type: add
4+
---
5+
6+
Instrument background job enqueues. Enqueuing a job now records an enqueue
7+
event on the active transaction, so enqueues made from within a web request or
8+
another job show up in the event timeline. This is recorded for Sidekiq
9+
(`enqueue.sidekiq`), Que (`enqueue.que`, plus `bulk_enqueue.que` for bulk
10+
enqueues on Que 2), Resque (`enqueue.resque`), Shoryuken (`enqueue.shoryuken`)
11+
and Delayed Job (`enqueue.delayed_job`). Each event is titled after the job
12+
being enqueued.
13+
14+
For Active Job, the `enqueue.active_job` event is now recorded by AppSignal's
15+
own instrumentation rather than by Rails' native `enqueue.active_job`
16+
notification. The native notification is suppressed so the enqueue is recorded
17+
once, and the event is now titled after the job being enqueued.
18+
19+
These enqueue events can be turned off with the
20+
`enable_job_enqueue_instrumentation` config option. Set it to `false` to stop
21+
recording enqueue events across all integrations, without affecting the
22+
instrumentation of the jobs themselves. It defaults to `true` and can also be
23+
set through the `APPSIGNAL_ENABLE_JOB_ENQUEUE_INSTRUMENTATION` environment
24+
variable.

β€Ž.changesets/instrument-que-enqueues.mdβ€Ž

Lines changed: 0 additions & 6 deletions
This file was deleted.

β€Ž.changesets/instrument-resque-enqueues.mdβ€Ž

Lines changed: 0 additions & 8 deletions
This file was deleted.

β€Ž.changesets/instrument-sidekiq-enqueues.mdβ€Ž

Lines changed: 0 additions & 8 deletions
This file was deleted.

β€Ž.changesets/title-sidekiq-delayed-enqueues-by-target.mdβ€Ž

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
Β (0)