Commit e03b091
authored
Dual-mode transaction and helper spec coverage
Audit of the transaction and helper specs for behaviors covered in only
one mode, agent or collector, that should be covered in both. Most gaps
were agent-only leftovers that assert through `to_h`-based matchers,
which do nothing in collector mode.
Fold the two send_error block specs into one dual-moded spec. It sets an
active transaction, calls `send_error` with a block, and checks the
block's metadata and the error land on `send_error`'s own transaction
while the active one is restored and left untouched. In collector mode
this confirms the active trace continues rather than being dropped or
left open.
Cover more behaviors in both modes: the `set_error` and `report_error`
blocks, `set_empty_params!`, the `add_params`, `add_session_data`,
`add_headers` and `add_custom_data` merge and block variants, `set_action`
and `set_namespace` setting the value, `report_error` not completing the
active transaction, and a transaction that reports a cause-less error
after one with causes.
Also add the one missing collector metric-coercion case, a symbol metric
name, to the OpenTelemetry metrics backend spec.1 parent b260823 commit e03b091
3 files changed
Lines changed: 445 additions & 120 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
49 | 57 | | |
50 | 58 | | |
51 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3943 | 3943 | | |
3944 | 3944 | | |
3945 | 3945 | | |
3946 | | - | |
| 3946 | + | |
| 3947 | + | |
3947 | 3948 | | |
3948 | 3949 | | |
3949 | 3950 | | |
| |||
3956 | 3957 | | |
3957 | 3958 | | |
3958 | 3959 | | |
| 3960 | + | |
| 3961 | + | |
| 3962 | + | |
| 3963 | + | |
| 3964 | + | |
| 3965 | + | |
| 3966 | + | |
| 3967 | + | |
| 3968 | + | |
| 3969 | + | |
| 3970 | + | |
| 3971 | + | |
| 3972 | + | |
| 3973 | + | |
| 3974 | + | |
| 3975 | + | |
| 3976 | + | |
| 3977 | + | |
3959 | 3978 | | |
3960 | 3979 | | |
3961 | 3980 | | |
| |||
0 commit comments