fix: Fix tests

Author: mkleszcz

packages/backend/apps/integrations/tests/test_clients.py

@@ -1,5 +1,6 @@
 from openai import APIError, OpenAI
 import pytest
+from unittest.mock import patch, Mock
 
 from apps.integrations.openai.client import OpenAIClient, OPEN_AI_API_ERROR_MSG
 from apps.integrations.openai.exceptions import OpenAIClientException
@@ -8,63 +9,47 @@
 
 
 class TestOpenAIClientGetSaasIdeas:
-    def test_success(self, mocker, openai_completion_mock, open_ai_completion_response_factory):
+    @patch('apps.integrations.openai.client.settings')
+    @patch.object(OpenAI, '__new__')
+    def test_success(self, mock_openai_new, mock_settings, open_ai_completion_response_factory):
+        OpenAIClient._client = None
+        mock_settings.OPENAI_API_KEY = 'sk-test-key'
+        mock_settings.OPENAI_MODEL = 'gpt-3.5-turbo'
+
         response_data = open_ai_completion_response_factory.create()
-        # Create a mock response object that mimics the chat completions API structure
-        mock_response = mocker.Mock()
-        mock_response.id = response_data["id"]
-        mock_response.object = response_data["object"]
-        mock_response.created = response_data["created"]
-        mock_response.model = response_data["model"]
-        # Chat completions API uses message.content instead of text
+        mock_response = Mock()
         mock_response.choices = [
-            mocker.Mock(
-                message=mocker.Mock(content=choice["text"]),
+            Mock(
+                message=Mock(content=choice["text"]),
                 index=choice["index"],
                 finish_reason=choice["finish_reason"],
             )
             for choice in response_data["choices"]
         ]
-        mock_response.usage = mocker.Mock(
-            prompt_tokens=response_data["usage"]["prompt_tokens"],
-            completion_tokens=response_data["usage"]["completion_tokens"],
-            total_tokens=response_data["usage"]["total_tokens"],
-        )
 
-        openai_completion_mock.return_value = mock_response
-        keywords = ['fitness', 'ai']
+        mock_client = Mock()
+        mock_client.chat.completions.create.return_value = mock_response
+        mock_openai_new.return_value = mock_client
 
+        keywords = ['fitness', 'ai']
         result = OpenAIClient.get_saas_ideas(keywords)
 
-        # The method uses chat.completions.create, not completions.create
-        # Verify it was called (the exact parameters depend on model fallback logic)
-        assert openai_completion_mock.called
-        # Result should be a string (the text content)
+        assert mock_client.chat.completions.create.called
         assert isinstance(result, str)
         assert len(result) > 0
 
-    def test_api_exception(self, mocker):
-        # Reset the client singleton to ensure fresh mock
+    @patch('apps.integrations.openai.client.settings')
+    @patch.object(OpenAI, '__new__')
+    def test_api_exception(self, mock_openai_new, mock_settings):
         OpenAIClient._client = None
+        mock_settings.OPENAI_API_KEY = 'sk-test-key'
+        mock_settings.OPENAI_MODEL = 'gpt-3.5-turbo'
 
-        # Mock the OpenAI client to raise APIError on both paths
         api_error = APIError(message="The server had an error while processing your request.", request=None, body=None)
 
-        # Create a mock client that raises errors on both completion paths
-        mock_client = mocker.Mock()
-        mock_chat = mocker.Mock()
-        mock_completions_chat = mocker.Mock()
-        mock_completions_chat.create.side_effect = api_error
-        mock_chat.completions = mock_completions_chat
-        mock_client.chat = mock_chat
-
-        # Mock completions.create for instruct models
-        mock_completions = mocker.Mock()
-        mock_completions.create.side_effect = api_error
-        mock_client.completions = mock_completions
-
-        # Patch OpenAI to return our mock
-        mocker.patch.object(OpenAI, '__new__', return_value=mock_client)
+        mock_client = Mock()
+        mock_client.chat.completions.create.side_effect = api_error
+        mock_openai_new.return_value = mock_client
 
         with pytest.raises(OpenAIClientException) as error:
             OpenAIClient.get_saas_ideas(['idea'])