Update to Selenium 4.31.0 +semver:feature (#268)

Update other package references
replace JsonNode with JsonElement? references
removed CDP V85 references as they are no longer supported by Firefox and Selenium
Update tasks in azure-pipelines yml
update license year

Author: mialeska

Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj

@@ -14,7 +14,7 @@
 	  <PackageTags>selenium webdriver browser automation image locator</PackageTags>
 	  <PackageLicenseFile>LICENSE</PackageLicenseFile>
 	  <PackageReadmeFile>README.md</PackageReadmeFile>
-	  <Copyright>Copyright 2024 Aquality Automation</Copyright>
+	  <Copyright>Copyright 2025 Aquality Automation</Copyright>
 	  <IsPackable>true</IsPackable>
   </PropertyGroup>
 

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj

@@ -15,7 +15,7 @@
     <PackageTags>selenium webdriver browser automation</PackageTags>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
 	<PackageReadmeFile>README.md</PackageReadmeFile>
-    <Copyright>Copyright 2024 Aquality Automation</Copyright>
+    <Copyright>Copyright 2025 Aquality Automation</Copyright>
     <IsPackable>true</IsPackable>
   </PropertyGroup>
 
@@ -91,8 +91,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aquality.Selenium.Core" Version="3.1.3" />
-    <PackageReference Include="WebDriverManager" Version="2.17.4" />
+    <PackageReference Include="Aquality.Selenium.Core" Version="3.2.1" />
+    <PackageReference Include="WebDriverManager" Version="2.17.5" />
   </ItemGroup>
 
 </Project>

Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml

@@ -1,10 +1,11 @@
 using Aquality.Selenium.Core.Utilities;
 using OpenQA.Selenium.DevTools;
-using OpenQA.Selenium.DevTools.V85.DOM;
-using OpenQA.Selenium.DevTools.V85.Emulation;
+using OpenQA.Selenium.DevTools.V135.DOM;
+using OpenQA.Selenium.DevTools.V135.Emulation;
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Text.Json;
 using System.Threading.Tasks;
 
 namespace Aquality.Selenium.Browsers
@@ -24,7 +25,10 @@ public static class DevToolsEmulationExtensions
         public static async Task<bool> CanEmulate(this DevToolsHandling devTools)
         {
             var response = await devTools.SendCommand(new CanEmulateCommandSettings());
-            return response["result"]?.ToString().Equals(bool.TrueString, StringComparison.OrdinalIgnoreCase) == true;
+            return response.HasValue && response.Value.TryGetProperty("result", out JsonElement resultElement)
+                && (resultElement.ValueKind == JsonValueKind.True ||
+                (resultElement.ValueKind == JsonValueKind.String &&
+                resultElement.GetString().Equals(bool.TrueString, StringComparison.OrdinalIgnoreCase)));
         }
 
         /// <summary>

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs

@@ -117,7 +117,7 @@ public object ExecuteCdpCommand(string commandName, Dictionary<string, object> c
             {
                 LogCommand(commandName, JsonSerializer.SerializeToNode(commandParameters), loggingOptions);
                 var result = driver.ExecuteCdpCommand(commandName, commandParameters);
-                var formattedResult = JsonSerializer.SerializeToNode(result);
+                var formattedResult = JsonSerializer.SerializeToElement(result);
                 LogCommandResult(formattedResult, loggingOptions);
                 return result;
             }
@@ -136,8 +136,8 @@ public object ExecuteCdpCommand(string commandName, Dictionary<string, object> c
         /// <param name="millisecondsTimeout">The execution timeout of the command in milliseconds.</param>
         /// <param name="throwExceptionIfResponseNotReceived"><see langword="true"/> to throw an exception if a response is not received; otherwise, <see langword="false"/>.</param>
         /// <param name="loggingOptions">Logging preferences.</param>
-        /// <returns>A JsonNode based on a command created with the specified command name and parameters.</returns>
-        public async Task<JsonNode> SendCommand(string commandName, JsonNode commandParameters = null, 
+        /// <returns>A JsonElement? based on a command created with the specified command name and parameters.</returns>
+        public async Task<JsonElement?> SendCommand(string commandName, JsonNode commandParameters = null, 
             CancellationToken cancellationToken = default, int? millisecondsTimeout = null, bool throwExceptionIfResponseNotReceived = true, 
             DevToolsCommandLoggingOptions loggingOptions = null)
         {
@@ -157,8 +157,8 @@ public async Task<JsonNode> SendCommand(string commandName, JsonNode commandPara
         /// <param name="millisecondsTimeout">The execution timeout of the command in milliseconds.</param>
         /// <param name="throwExceptionIfResponseNotReceived"><see langword="true"/> to throw an exception if a response is not received; otherwise, <see langword="false"/>.</param>
         /// <param name="loggingOptions">Logging preferences.</param>
-        /// <returns>A JsonNode based on a command created with the specified command name and parameters.</returns>
-        public async Task<JsonNode> SendCommand(ICommand commandWithParameters,
+        /// <returns>A JsonElement? based on a command created with the specified command name and parameters.</returns>
+        public async Task<JsonElement?> SendCommand(ICommand commandWithParameters,
             CancellationToken cancellationToken = default, int? millisecondsTimeout = null, bool throwExceptionIfResponseNotReceived = true, 
             DevToolsCommandLoggingOptions loggingOptions = null)
         {
@@ -183,7 +183,7 @@ protected virtual void LogCommand(string commandName, JsonNode commandParameters
             }
         }
 
-        protected virtual void LogCommandResult(JsonNode result, DevToolsCommandLoggingOptions loggingOptions = null)
+        protected virtual void LogCommandResult(JsonElement? result, DevToolsCommandLoggingOptions loggingOptions = null)
         {
             var logging = (loggingOptions ?? new DevToolsCommandLoggingOptions()).Result;
             if (IsNotEmpty(result) && logging.Enabled)
@@ -192,6 +192,31 @@ protected virtual void LogCommandResult(JsonNode result, DevToolsCommandLoggingO
             }
         }
 
+        private static bool IsNotEmpty(JsonElement? jsonElement)
+        {
+            if (!jsonElement.HasValue)
+            {
+                return false;
+            }
+
+            var element = jsonElement.Value;
+            switch (element.ValueKind)
+            {
+                case JsonValueKind.Object:
+                    return element.EnumerateObject().Any();
+                case JsonValueKind.Array:
+                    return element.EnumerateArray().Any();
+                case JsonValueKind.String:
+                    return !string.IsNullOrEmpty(element.GetString());
+                case JsonValueKind.Number:
+                case JsonValueKind.True:
+                case JsonValueKind.False:
+                    return true;
+                default:
+                    return false;
+            }
+        }
+
         private static bool IsNotEmpty(JsonNode jsonNode)
         {
             return jsonNode is JsonArray array ? array.Any() : (jsonNode as JsonObject).Any();

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsHandling.cs

@@ -1,8 +1,8 @@
-using OpenQA.Selenium.DevTools.V85.Performance;
+using OpenQA.Selenium.DevTools.V135.Performance;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
-using System.Text.Json.Nodes;
+using System.Text.Json;
 using System.Threading.Tasks;
 
 namespace Aquality.Selenium.Browsers
@@ -42,9 +42,9 @@ public static async Task EnablePerformanceMonitoring(this DevToolsHandling devTo
         /// <returns>A task for asynchronous command with current values for run-time metrics as result.</returns>
         public static async Task<IDictionary<string, double>> GetPerformanceMetrics(this DevToolsHandling devTools)
         {
-            JsonNode result = await devTools.SendCommand(new GetMetricsCommandSettings());
-            return (result["metrics"].AsArray())
-                .ToDictionary(item => item["name"].ToString(), item => double.Parse(item["value"].ToString(), CultureInfo.InvariantCulture));
+            JsonElement? result = await devTools.SendCommand(new GetMetricsCommandSettings());
+            return (result.Value.GetProperty("metrics").EnumerateArray())
+                .ToDictionary(item => item.GetProperty("name").ToString(), item => double.Parse(item.GetProperty("value").ToString(), CultureInfo.InvariantCulture));
         }
     }
 }

Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs

@@ -29,12 +29,12 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="nunit" Version="4.2.2" />
-    <PackageReference Include="NUnit3TestAdapter" Version="4.6.0">
+    <PackageReference Include="nunit" Version="4.3.2" />
+    <PackageReference Include="NUnit3TestAdapter" Version="5.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
   </ItemGroup>
 
   <ItemGroup>

Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj

@@ -5,7 +5,7 @@
 using Aquality.Selenium.Tests.Integration.TestApp.TheInternet.Forms;
 using NUnit.Framework;
 using OpenQA.Selenium;
-using OpenQA.Selenium.DevTools.V85.Emulation;
+using OpenQA.Selenium.DevTools.V135.Emulation;
 using System;
 using System.Collections.Generic;
 
@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec
         {
             void setAction(long width, long height, bool isMobile, double scaleFactor)
             {
-                var parameters = new OpenQA.Selenium.DevTools.V131.Emulation.SetDeviceMetricsOverrideCommandSettings
+                var parameters = new OpenQA.Selenium.DevTools.V134.Emulation.SetDeviceMetricsOverrideCommandSettings
                 {
-                    DisplayFeature = new OpenQA.Selenium.DevTools.V131.Emulation.DisplayFeature
+                    DisplayFeature = new OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeature
                     {
-                        Orientation = OpenQA.Selenium.DevTools.V131.Emulation.DisplayFeatureOrientationValues.Horizontal
+                        Orientation = OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeatureOrientationValues.Horizontal
                     },
                     Width = width,
                     Height = height,

Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2024 Aquality Automation
+   Copyright 2025 Aquality Automation
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

LICENSE

@@ -12,37 +12,34 @@ stages:
 
   jobs:
   - job: sonar
-    displayName: Analyse code with SonarQube
+    displayName: Analyze code with SonarQube
 
     steps:
-    - task: SonarCloudPrepare@2
+    - task: SonarCloudPrepare@3
       displayName: 'Prepare SonarCloud analysis'
       inputs:
         SonarCloud: 'SonarCloud'
         organization: 'aqualityautomation'
-        scannerMode: 'MSBuild'
+        scannerMode: 'dotnet'
         projectKey: 'aquality-automation_aquality-selenium-dotnet'
         projectName: 'aquality-selenium-dotnet'
         projectVersion: '$(Build.BuildNumber)'
-        extraProperties: |
-          sonar.coverage.exclusions=**/**
+        extraProperties: 'sonar.coverage.exclusions=**/**'
 
     - task: DotNetCoreCLI@2
       displayName: 'Build solution'
-      env: 
-        MSBUILDSINGLELOADCONTEXT: 1  # https://github.com/SpecFlowOSS/SpecFlow/issues/1912
       inputs:
         command: 'build'
         projects: Aquality.Selenium/Aquality.Selenium.sln
         arguments: -c $(buildConfiguration)      
 
-    - task: SonarCloudAnalyze@2
-      displayName: 'Run SonarCloud code analysis'
-      continueOnError: true
+    - task: SonarCloudAnalyze@3
       inputs:
         jdkversion: 'JAVA_HOME_17_X64'
+      displayName: 'Run SonarCloud code analysis'
+      continueOnError: true
 
-    - task: SonarCloudPublish@2
+    - task: SonarCloudPublish@3
       displayName: 'Publish SonarCloud quality gate results'
       inputs:
         pollingTimeoutSec: '300'
@@ -83,16 +80,18 @@ stages:
     - script: dotnet pack Aquality.Selenium\Aquality.Selenium.sln -c $(buildConfiguration) -p:Version=$(GitVersion.NuGetVersion) -o $(Build.ArtifactStagingDirectory)
       displayName: 'Pack to NuGet package'
 
-    - task: GitHubRelease@0
+    - task: GitHubRelease@1
       displayName: 'Create tag on GitHub'
       inputs:
         gitHubConnection: 'github.com_aqualityautomation'
         repositoryName: 'aquality-automation/aquality-selenium-dotnet'
         action: 'create'
+        target: '$(Build.SourceVersion)'
+        tagSource: 'userSpecifiedTag'
         tag: 'v$(GitVersion.NuGetVersion)'
-        title: 'v$(GitVersion.NuGetVersion)'
-        tagSource: 'manual'
-        isPreRelease: contains(variables['GitVersion.NuGetVersion'], '-')
+        isDraft: contains(variables['GitVersion.NuGetVersion'], '-')
+        changeLogCompareToRelease: 'lastFullRelease'
+        changeLogType: 'commitBased'
 
     - task: NuGetCommand@2
       displayName: 'Push NuGet package'