Skip to content

Is there a reason for ignoring artifactVersion in GAV validation for jar files ?  #260

@john-d8r

Description

@john-d8r

When parsing jar files, go-dep-parser validates GAV info against maven repo when pom.properties is not found

And in the validation, artifactVersion is currently being ignored.

if manifestProps.Valid() {
// Even if MANIFEST.MF is found, the groupId and artifactId might not be valid.
// We have to make sure that the artifact exists actually.
if ok, _ := p.client.Exists(manifestProps.GroupID, manifestProps.ArtifactID); ok {
// If groupId and artifactId are valid, they will be returned.
return append(libs, manifestProps.Library()), nil, nil
}
}

Is this intentional ? (any reason for not including version here)

Thanks in advance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions