Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Vulnerabilities #1408

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fixing Vulnerabilities #1408

merged 1 commit into from
Feb 26, 2025

Conversation

sm171190
Copy link
Contributor

In this change we have upgraded the base image to alpine 3.21 and upgraded the vulnerable golang.org/net package to a cleaner version

Description

Related issues

  • Close #XXX

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@mjshastha
Copy link
Collaborator

@sm171190 You'll also need to update the base image in other Docker files.

@sm171190
Copy link
Contributor Author

@sm171190 You'll also need to update the base image in other Docker files.

  • Done. Can you please review ? Thanks

deven0t
deven0t reviewed Feb 25, 2025
View reviewed changes
build/starboard/Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM alpine:3.19
qqFROM alpine:3.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this

@sm171190
Fixing Vulnerabilities
8e4df7b 
In this change we have upgraded the base image to alpine 3.21 and upgraded the vulnerable golang.org/net package to a cleaner version
@sm171190 sm171190 requested a review from deven0t February 25, 2025 13:13
deven0t
deven0t approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@deven0t deven0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

mjshastha
mjshastha approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@mjshastha mjshastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content with the changes.

@mjshastha mjshastha merged commit fa1df5f into aquasecurity:main Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deven0t deven0t deven0t approved these changes

@mjshastha mjshastha mjshastha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sm171190 @mjshastha @deven0t