Add commercial evidence artifact completeness evaluation

Author: ammarheidari

README.md

@@ -73,7 +73,7 @@ The first production milestone is M3UA over a transport abstraction. SCCP, TCAP,
 | RC publish and commercial gate | Phase 35 complete: dry-run release rehearsal, gated NuGet prerelease publication, retained release notes, retained migration notes, final commercial readiness reporting, RC/stable decisioning, RC publication evidence manifest, release workflow channel wiring, status reporting, and final commercial gate report are available; stable publication remains blocked until commercial evidence is complete |
 | Commercial evidence readiness lockdown | Phase 36 foundation-complete: release target locking, protected secret readiness, evidence retention mapping, commercial evidence checklist, release preflight, protected release environments, dossier handoff, go/no-go gating, status reporting, and final validation are available; RC and stable publication remain blocked until retained commercial release evidence is complete |
 | Commercial evidence execution orchestration | Phase 37 foundation-complete: evidence execution run identity, stage catalog, operator command plan, execution environment contract, artifact collection manifest, digest/redaction verification, blocker classification, retry/resume policy, status reporting, and final validation are available; real retained execution artifacts are still required before commercial publication |
-| Commercial evidence artifact intake | Phase 38 in progress: artifact intake target identity, artifact source registration, SHA-256 digest coverage, and redaction review are available, binding a stable intake id, reviewer identity, UTC receipt time, run-scoped dossier root, concrete source paths, unique retained dossier paths, retained digests, and trace-bearing artifact approvals to a governed execution run; completeness evaluation, dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain |
+| Commercial evidence artifact intake | Phase 38 in progress: artifact intake target identity, artifact source registration, SHA-256 digest coverage, redaction review, and completeness evaluation are available, binding a stable intake id, reviewer identity, UTC receipt time, run-scoped dossier root, concrete source paths, unique retained dossier paths, retained digests, trace-bearing artifact approvals, and explicit intake blockers to a governed execution run; dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain |
 
 ## Requirements
 

docs/PHASE38_COMMERCIAL_EVIDENCE_ARTIFACT_INTAKE.md

@@ -51,6 +51,16 @@ The digest manifest is required before redaction review and promotion handoff be
 
 Each required review records the retained path, artifact kind, reviewer identity, UTC review time, approval state, and notes. Rejected or missing reviews block the intake from moving into completeness evaluation.
 
+## Unit 5 - Artifact Completeness Evaluation
+
+`SigtranCommercialEvidenceArtifactCompleteness` evaluates whether intake can move into dossier reporting:
+
+- Source registration must be complete.
+- Digest coverage must be complete.
+- Redaction review must be complete.
+
+The evaluator returns explicit blocker codes such as `artifact-source-registration-incomplete`, `artifact-digest-coverage-incomplete`, and `redaction-review-incomplete` so release operators can correct the right evidence area without guessing.
+
 ## Validation
 
 Each unit in this phase is validated with:

docs/PHASE38_SUMMARY.md

@@ -8,7 +8,8 @@ Phase 38 prepares the SDK to receive real execution artifacts and convert them i
 - Artifact source manifest that maps every required expected execution artifact to a concrete source path and a unique retained dossier path.
 - Artifact digest manifest that requires SHA-256 coverage for every retained source.
 - Redaction review manifest that requires approved review for trace-bearing retained artifacts.
+- Artifact completeness evaluator that reports explicit source, digest, and redaction blockers.
 
 ## Readiness Position
 
-The phase is in progress. Artifact intake identity, source registration, digest coverage, and redaction review are available. Completeness evaluation, dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain.
+The phase is in progress. Artifact intake identity, source registration, digest coverage, redaction review, and completeness evaluation are available. Dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain.

docs/PHASE_INDEX.md

@@ -42,7 +42,7 @@ This index is the complete phase map for Sigtran.NET. It links each phase to the
 | 35 | RC publish and commercial gate | [Phase 35 RC Publish And Commercial Gate](PHASE35_RC_PUBLISH_COMMERCIAL_GATE.md), [Phase 35 Summary](PHASE35_SUMMARY.md), [Phase 35 Commercial Gate Report](PHASE35_COMMERCIAL_GATE_REPORT.md) | RC gate foundation complete; stable publication blocked |
 | 36 | Commercial evidence readiness lockdown | [Phase 36 Commercial Evidence Readiness Lockdown](PHASE36_COMMERCIAL_EVIDENCE_READINESS_LOCKDOWN.md), [Phase 36 Summary](PHASE36_SUMMARY.md) | Foundation complete; real commercial evidence still required |
 | 37 | Commercial evidence execution orchestration | [Phase 37 Commercial Evidence Execution Orchestration](PHASE37_COMMERCIAL_EVIDENCE_EXECUTION_ORCHESTRATION.md), [Phase 37 Summary](PHASE37_SUMMARY.md) | Foundation complete; real execution artifacts still required |
-| 38 | Commercial evidence artifact intake | [Phase 38 Commercial Evidence Artifact Intake](PHASE38_COMMERCIAL_EVIDENCE_ARTIFACT_INTAKE.md), [Phase 38 Summary](PHASE38_SUMMARY.md) | In progress; redaction review complete |
+| 38 | Commercial evidence artifact intake | [Phase 38 Commercial Evidence Artifact Intake](PHASE38_COMMERCIAL_EVIDENCE_ARTIFACT_INTAKE.md), [Phase 38 Summary](PHASE38_SUMMARY.md) | In progress; completeness evaluation complete |
 
 ## Current Commercial Gate
 

docs/SDK_ROADMAP.md

@@ -339,7 +339,7 @@ Status: Phase 37 is foundation-complete. Evidence execution run identity binds a
 - Register artifact sources, digests, redaction reviews, completeness results, dossier reports, promotion handoff, and execution-to-dossier bridging.
 - Keep intake foundation separate from commercial publication: intake can prove that artifacts are ready for review, but publication remains blocked until all retained evidence is complete and approved.
 
-Status: Phase 38 is in progress. Artifact intake target identity now binds a stable intake id, reviewer identity, UTC receipt time, and run-scoped dossier root to a governed commercial evidence execution run. Artifact source registration now maps every required expected execution artifact to a concrete source path and unique retained dossier path while rejecting floating `artifacts/latest` aliases. Digest coverage now records SHA-256 values for every retained source and blocks invalid digest values. Redaction review now requires approved reviewer records for trace-bearing retained artifacts. Completeness evaluation, dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain in progress.
+Status: Phase 38 is in progress. Artifact intake target identity now binds a stable intake id, reviewer identity, UTC receipt time, and run-scoped dossier root to a governed commercial evidence execution run. Artifact source registration now maps every required expected execution artifact to a concrete source path and unique retained dossier path while rejecting floating `artifacts/latest` aliases. Digest coverage now records SHA-256 values for every retained source and blocks invalid digest values. Redaction review now requires approved reviewer records for trace-bearing retained artifacts. Completeness evaluation now reports explicit source, digest, and redaction blockers. Dossier reporting, promotion handoff, execution bridge, status reporting, and final validation remain in progress.
 
 ## Recommended First Deliverable
 

src/Sigtran.NET.Tests/Program.cs

@@ -291,6 +291,7 @@
 Run("SIGTRAN commercial evidence artifact sources cover expected execution artifacts", SigtranCommercialEvidenceArtifactSourcesCoverExpectedExecutionArtifacts);
 Run("SIGTRAN commercial evidence artifact digests cover retained sources", SigtranCommercialEvidenceArtifactDigestsCoverRetainedSources);
 Run("SIGTRAN commercial evidence redaction reviews approve trace-bearing artifacts", SigtranCommercialEvidenceRedactionReviewsApproveTraceBearingArtifacts);
+Run("SIGTRAN commercial evidence artifact completeness reports blockers", SigtranCommercialEvidenceArtifactCompletenessReportsBlockers);
 Run("SIGTRAN status capabilities use domain documentation labels", SigtranStatusCapabilitiesUseDomainDocumentationLabels);
 Run("Native SCTP platform probe reports socket creation capability", NativeSctpPlatformProbeReportsSocketCreationCapability);
 Run("Native SCTP socket factory creates or reports unsupported platform", NativeSctpSocketFactoryCreatesOrReportsUnsupportedPlatform);
@@ -4863,10 +4864,7 @@ static void SigtranCommercialEvidenceArtifactDigestsCoverRetainedSources()
 static void SigtranCommercialEvidenceRedactionReviewsApproveTraceBearingArtifacts()
 {
     SigtranCommercialEvidenceArtifactDigestManifest digests = CreateDefaultCommercialEvidenceArtifactDigestManifest();
-    SigtranCommercialEvidenceRedactionReviewManifest reviews = SigtranCommercialEvidenceRedactionReviews.CreateApproved(
-        digests,
-        "release-review",
-        DateTimeOffset.UtcNow);
+    SigtranCommercialEvidenceRedactionReviewManifest reviews = CreateDefaultCommercialEvidenceRedactionReviewManifest();
     SigtranCommercialEvidenceRedactionReview firstReview = reviews.Reviews[0];
     SigtranCommercialEvidenceRedactionReviewManifest rejectedReviews = new(
         digests,
@@ -4881,6 +4879,33 @@ static void SigtranCommercialEvidenceRedactionReviewsApproveTraceBearingArtifact
     Assert(!rejectedReviews.IsReady, "rejected redaction review should block readiness");
 }
 
+static void SigtranCommercialEvidenceArtifactCompletenessReportsBlockers()
+{
+    SigtranCommercialEvidenceArtifactDigestManifest digests = CreateDefaultCommercialEvidenceArtifactDigestManifest();
+    SigtranCommercialEvidenceRedactionReviewManifest reviews = CreateDefaultCommercialEvidenceRedactionReviewManifest();
+    SigtranCommercialEvidenceArtifactCompletenessResult complete = SigtranCommercialEvidenceArtifactCompleteness.Evaluate(reviews);
+    SigtranCommercialEvidenceRedactionReview firstReview = reviews.Reviews[0];
+    SigtranCommercialEvidenceRedactionReviewManifest rejectedReviews = new(
+        digests,
+        [
+            new(firstReview.RetainedPath, firstReview.Kind, "release-review", DateTimeOffset.UtcNow, approved: false, "Sensitive data still present.")
+        ]);
+    SigtranCommercialEvidenceArtifactCompletenessResult blocked = SigtranCommercialEvidenceArtifactCompleteness.Evaluate(rejectedReviews);
+
+    Assert(complete.IsComplete, complete.Describe());
+    AssertEqual(0, complete.Blockers.Count, "complete artifact intake blockers");
+    Assert(!blocked.IsComplete, blocked.Describe());
+    Assert(blocked.Blockers.Contains("redaction-review-incomplete"), "blocked completeness should report redaction review");
+}
+
+static SigtranCommercialEvidenceRedactionReviewManifest CreateDefaultCommercialEvidenceRedactionReviewManifest()
+{
+    return SigtranCommercialEvidenceRedactionReviews.CreateApproved(
+        CreateDefaultCommercialEvidenceArtifactDigestManifest(),
+        "release-review",
+        DateTimeOffset.UtcNow);
+}
+
 static SigtranCommercialEvidenceArtifactDigestManifest CreateDefaultCommercialEvidenceArtifactDigestManifest()
 {
     return SigtranCommercialEvidenceArtifactDigests.CreateCovered(

src/Sigtran.NET/Core/Utilities/SigtranCommercialEvidenceArtifactCompleteness.cs

@@ -0,0 +1,80 @@
+namespace Sigtran.NET.Core.Utilities;
+
+/// <summary>
+/// Describes commercial evidence artifact intake completeness.
+/// </summary>
+public sealed class SigtranCommercialEvidenceArtifactCompletenessResult
+{
+    /// <summary>Creates a commercial evidence artifact completeness result.</summary>
+    /// <param name="redactionReviewManifest">The redaction review manifest.</param>
+    /// <param name="blockers">The completeness blocker codes.</param>
+    public SigtranCommercialEvidenceArtifactCompletenessResult(
+        SigtranCommercialEvidenceRedactionReviewManifest redactionReviewManifest,
+        IReadOnlyList<string> blockers)
+    {
+        RedactionReviewManifest = redactionReviewManifest ?? throw new ArgumentNullException(nameof(redactionReviewManifest));
+        ArgumentNullException.ThrowIfNull(blockers);
+        Blockers = blockers.ToArray();
+    }
+
+    /// <summary>The redaction review manifest.</summary>
+    public SigtranCommercialEvidenceRedactionReviewManifest RedactionReviewManifest { get; }
+
+    /// <summary>The completeness blocker codes.</summary>
+    public IReadOnlyList<string> Blockers { get; }
+
+    /// <summary>Whether source registration is complete.</summary>
+    public bool SourceRegistrationComplete => RedactionReviewManifest.DigestManifest.SourceManifest.IsReady;
+
+    /// <summary>Whether digest coverage is complete.</summary>
+    public bool DigestCoverageComplete => RedactionReviewManifest.DigestManifest.IsReady;
+
+    /// <summary>Whether redaction review is complete.</summary>
+    public bool RedactionReviewComplete => RedactionReviewManifest.IsReady;
+
+    /// <summary>Whether every required artifact is ready for dossier reporting.</summary>
+    public bool IsComplete => Blockers.Count == 0
+        && SourceRegistrationComplete
+        && DigestCoverageComplete
+        && RedactionReviewComplete;
+
+    /// <summary>Formats a compact artifact completeness summary.</summary>
+    /// <returns>The artifact completeness summary.</returns>
+    public string Describe()
+    {
+        return $"commercialEvidenceArtifactCompleteness={IsComplete} blockers={Blockers.Count} intake={RedactionReviewManifest.DigestManifest.SourceManifest.Target.IntakeId}";
+    }
+}
+
+/// <summary>
+/// Provides commercial evidence artifact completeness evaluation.
+/// </summary>
+public static class SigtranCommercialEvidenceArtifactCompleteness
+{
+    /// <summary>Evaluates artifact intake completeness.</summary>
+    /// <param name="redactionReviewManifest">The redaction review manifest.</param>
+    /// <returns>The artifact completeness result.</returns>
+    public static SigtranCommercialEvidenceArtifactCompletenessResult Evaluate(
+        SigtranCommercialEvidenceRedactionReviewManifest redactionReviewManifest)
+    {
+        ArgumentNullException.ThrowIfNull(redactionReviewManifest);
+        List<string> blockers = [];
+
+        if (!redactionReviewManifest.DigestManifest.SourceManifest.IsReady)
+        {
+            blockers.Add("artifact-source-registration-incomplete");
+        }
+
+        if (!redactionReviewManifest.DigestManifest.IsReady)
+        {
+            blockers.Add("artifact-digest-coverage-incomplete");
+        }
+
+        if (!redactionReviewManifest.IsReady)
+        {
+            blockers.Add("redaction-review-incomplete");
+        }
+
+        return new(redactionReviewManifest, blockers);
+    }
+}