Rename props

Signed-off-by: Milos Dzepina <milos@aragon.org>

Author: milosh86

src/modules/components/proposal/proposalActionSimulationStructure/proposalActionSimulationStructure.stories.tsx

@@ -52,7 +52,7 @@ export const Failure: Story = {
 export const Loading: Story = {
     args: {
         totalActions: 5,
-        isSimulating: true,
+        isLoading: true,
     },
 };
 
@@ -119,7 +119,7 @@ export const NotSimulatable: Story = {
             url: 'https://dashboard.tenderly.co/simulation/12345',
             status: 'success',
         },
-        isSimulatable: false,
+        isEnabled: false,
     },
 };
 

src/modules/components/proposal/proposalActionSimulationStructure/proposalActionSimulationStructure.test.tsx

@@ -43,25 +43,29 @@ describe('<ProposalActionSimulationStructure /> component', () => {
 
     it('renders relative time for recent simulation', () => {
         const recentTime = DateTime.now().minus({ days: 2 });
-        render(createTestComponent({ 
-            lastSimulation: {
-                timestamp: recentTime.toMillis(),
-                url: 'https://dashboard.tenderly.co/simulation/12345',
-                status: 'success'
-            }
-        }));
+        render(
+            createTestComponent({
+                lastSimulation: {
+                    timestamp: recentTime.toMillis(),
+                    url: 'https://dashboard.tenderly.co/simulation/12345',
+                    status: 'success',
+                },
+            }),
+        );
         expect(screen.getByText('2 days ago')).toBeInTheDocument();
     });
 
     it('renders "Now" for very recent simulation', () => {
         const veryRecentTime = DateTime.now().minus({ seconds: 30 });
-        render(createTestComponent({ 
-            lastSimulation: {
-                timestamp: veryRecentTime.toMillis(),
-                url: 'https://dashboard.tenderly.co/simulation/12345',
-                status: 'success'
-            }
-        }));
+        render(
+            createTestComponent({
+                lastSimulation: {
+                    timestamp: veryRecentTime.toMillis(),
+                    url: 'https://dashboard.tenderly.co/simulation/12345',
+                    status: 'success',
+                },
+            }),
+        );
         expect(screen.getByText('Now')).toBeInTheDocument();
     });
 
@@ -71,8 +75,8 @@ describe('<ProposalActionSimulationStructure /> component', () => {
                 lastSimulation: {
                     timestamp: DateTime.now().toMillis(),
                     url: 'https://dashboard.tenderly.co/simulation/12345',
-                    status: 'success'
-                }
+                    status: 'success',
+                },
             }),
         );
         expect(screen.getByText('Likely to succeed')).toBeInTheDocument();
@@ -84,8 +88,8 @@ describe('<ProposalActionSimulationStructure /> component', () => {
                 lastSimulation: {
                     timestamp: DateTime.now().toMillis(),
                     url: 'https://dashboard.tenderly.co/simulation/12345',
-                    status: 'failure'
-                }
+                    status: 'failure',
+                },
             }),
         );
         expect(screen.getByText('Likely to fail')).toBeInTheDocument();
@@ -99,7 +103,7 @@ describe('<ProposalActionSimulationStructure /> component', () => {
     it('renders loading state when execution status is loading', () => {
         render(
             createTestComponent({
-                isSimulating: true,
+                isLoading: true,
             }),
         );
 
@@ -113,7 +117,7 @@ describe('<ProposalActionSimulationStructure /> component', () => {
     });
 
     it('hides simulate button when isSimulatable is false', () => {
-        render(createTestComponent({ isSimulatable: false }));
+        render(createTestComponent({ isEnabled: false }));
 
         expect(screen.queryByText(/simulate/i)).toBeNull();
     });

src/modules/components/proposal/proposalActionSimulationStructure/proposalActionSimulationStructure.tsx

@@ -25,11 +25,11 @@ export interface IProposalActionSimulationStructureProps {
     /**
      * Whether simulation is currently running.
      */
-    isSimulating?: boolean;
+    isLoading?: boolean;
     /**
      * Whether the proposal can be simulated.
      */
-    isSimulatable?: boolean;
+    isEnabled?: boolean;
     /**
      * Callback when simulate again button is clicked.
      */
@@ -46,7 +46,7 @@ export interface IProposalActionSimulationStructureProps {
 }
 
 export const ProposalActionSimulationStructure: React.FC<IProposalActionSimulationStructureProps> = (props) => {
-    const { totalActions, lastSimulation, isSimulating, isSimulatable = true, onSimulate, className, error } = props;
+    const { totalActions, lastSimulation, isLoading, isEnabled = true, onSimulate, className, error } = props;
 
     const { copy } = useGukModulesContext();
     const simulationCopy = copy.proposalActionSimulationStructure;
@@ -104,7 +104,7 @@ export const ProposalActionSimulationStructure: React.FC<IProposalActionSimulati
                 </DefinitionList.Item>
 
                 <DefinitionList.Item term={copy.proposalActionSimulationStructure.lastSimulationTerm}>
-                    {isSimulating ? (
+                    {isLoading ? (
                         <span className="text-primary-400 flex items-center gap-2 md:gap-3">
                             <Spinner size="md" variant="primary" />
                             {simulationCopy.simulating}
@@ -117,7 +117,7 @@ export const ProposalActionSimulationStructure: React.FC<IProposalActionSimulati
                 <DefinitionList.Item term={copy.proposalActionSimulationStructure.executableTerm}>
                     <div className="flex w-full items-center justify-between">
                         <div className="flex items-center gap-2">
-                            {isSimulating ? (
+                            {isLoading ? (
                                 <span className="text-primary-400 flex items-center gap-2 md:gap-3">
                                     <Spinner size="md" variant="primary" />
                                     {simulationCopy.simulating}
@@ -139,12 +139,12 @@ export const ProposalActionSimulationStructure: React.FC<IProposalActionSimulati
 
             <div
                 className={classNames('flex flex-col gap-2 md:flex-row md:justify-between', {
-                    'md:justify-end': !isSimulatable,
+                    'md:justify-end': !isEnabled,
                 })}
             >
-                {isSimulatable && (
-                    <Button variant="secondary" size="md" onClick={onSimulate} isLoading={isSimulating}>
-                        {isSimulating
+                {isEnabled && (
+                    <Button variant="secondary" size="md" onClick={onSimulate} isLoading={isLoading}>
+                        {isLoading
                             ? copy.proposalActionSimulationStructure.simulating
                             : lastSimulation
                               ? copy.proposalActionSimulationStructure.simulateAgain