Address PR commets

Signed-off-by: Milos Dzepina <milos@aragon.org>

Author: milosh86

src/core/components/dropdown/dropdownItem/dropdownItem.tsx

@@ -83,6 +83,15 @@ export const DropdownItem: React.FC<IDropdownItemProps> = (props) => {
         };
     }
 
+    const handleSelect = (event: Event) => {
+        // For submit buttons, we need to prevent the dropdown from closing immediately to allow the form submission to complete properly
+        if (renderSubmitButton) {
+            event.preventDefault();
+        }
+
+        props.onSelect?.(event);
+    };
+
     const defaultIcon = renderLink ? IconType.LINK_EXTERNAL : selected ? IconType.CHECKMARK : undefined;
     const processedIcon = icon ?? defaultIcon;
 
@@ -102,14 +111,7 @@ export const DropdownItem: React.FC<IDropdownItemProps> = (props) => {
                 { 'flex-row-reverse justify-end': iconPosition === 'left' && icon != null },
                 className,
             )}
-            onSelect={(event) => {
-                // For submit buttons, we need to prevent the dropdown from closing immediately to allow the form submission to complete properly
-                if (renderSubmitButton) {
-                    event.preventDefault();
-                }
-
-                props.onSelect?.(event);
-            }}
+            onSelect={handleSelect}
             {...otherProps}
         >
             <ItemWrapper {...itemWrapperProps}>

src/modules/components/action/actionSimulation/actionSimulation.test.tsx

@@ -1,5 +1,4 @@
 import { render, screen } from '@testing-library/react';
-import { DateTime } from 'luxon';
 import { GukCoreProvider } from '../../../../core';
 import { modulesCopy } from '../../../assets';
 import { ActionSimulation } from './actionSimulation';
@@ -47,11 +46,7 @@ describe('<ActionSimulation /> component', () => {
     it('renders the execution status label', () => {
         render(
             createTestComponent({
-                lastSimulation: {
-                    timestamp: DateTime.now().toMillis(),
-                    url: 'https://dashboard.tenderly.co/simulation/12345',
-                    status: 'success',
-                },
+                lastSimulation: { timestamp: 0, url: '', status: 'success' },
             }),
         );
         expect(screen.getByText(actionSimulationCopy.likelyToSucceed)).toBeInTheDocument();
@@ -60,11 +55,7 @@ describe('<ActionSimulation /> component', () => {
     it('renders failure status label', () => {
         render(
             createTestComponent({
-                lastSimulation: {
-                    timestamp: DateTime.now().toMillis(),
-                    url: 'https://dashboard.tenderly.co/simulation/12345',
-                    status: 'failed',
-                },
+                lastSimulation: { timestamp: 0, url: '', status: 'failed' },
             }),
         );
         expect(screen.getByText(actionSimulationCopy.likelyToFail)).toBeInTheDocument();
@@ -76,24 +67,20 @@ describe('<ActionSimulation /> component', () => {
     });
 
     it('renders loading state when execution status is loading', () => {
-        render(
-            createTestComponent({
-                isLoading: true,
-            }),
-        );
+        render(createTestComponent({ isLoading: true }));
 
         expect(screen.getAllByText(actionSimulationCopy.simulating)).toHaveLength(3);
     });
 
-    it('shows simulate button by default when isSimulatable is not specified', () => {
+    it('shows simulate button by default when isEnabled is not specified', () => {
         render(createTestComponent());
 
         expect(screen.getByText(actionSimulationCopy.simulate)).toBeInTheDocument();
     });
 
-    it('hides simulate button when isSimulatable is false', () => {
+    it('hides simulate button when isEnabled is false', () => {
         render(createTestComponent({ isEnabled: false }));
 
-        expect(screen.queryByText(actionSimulationCopy.simulate)).toBeNull();
+        expect(screen.queryByText(actionSimulationCopy.simulate)).not.toBeInTheDocument();
     });
 });

src/modules/components/action/actionSimulation/actionSimulation.tsx

@@ -81,7 +81,7 @@ export const ActionSimulation: React.FC<IActionSimulationProps> = (props) => {
                                     <div className="flex size-6 items-center justify-center">
                                         <AvatarIcon icon={statusConfig.icon} size="sm" variant={statusConfig.variant} />
                                     </div>
-                                    <span className={classNames('text-sm', statusConfig.textColor)}>
+                                    <span className={classNames('text-sm md:text-base', statusConfig.textColor)}>
                                         {statusConfig.label}
                                     </span>
                                 </>