-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
needs: designdiscussion on design is needed; can be done within the existing codebase and mathematical structurediscussion on design is needed; can be done within the existing codebase and mathematical structureon: codeimprovements, additions and fixes on the codebaseimprovements, additions and fixes on the codebasepriority: mediumif possible by the new releaseif possible by the new release
Description
In the code in abstract_model we compute :
for k in ("nll_attach", "nll_regul_ind_sum"):
suff_stats[k] = state[k]
suff_stats["nll_tot"] = (
suff_stats["nll_attach"] + suff_stats["nll_regul_ind_sum"]
)
1st issue : At the end of the fit it does not appear in the state, we can not print it. We have the same problem also with :
- "nll_regul_pop_sum" (calculated as : "nll_regul_log_g" + "nll_regul_log_v0" + "nll_regul_betas"
- "nll_regul_all_sum" (calculated as "nll_regul_pop_sum" + nll_regul_ind_sum)
the terms inside the parentheses are well calculated in the end
2nd issue : It's not calculated correctly. It should also add the term "nll_regul_pop_sum"
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
needs: designdiscussion on design is needed; can be done within the existing codebase and mathematical structurediscussion on design is needed; can be done within the existing codebase and mathematical structureon: codeimprovements, additions and fixes on the codebaseimprovements, additions and fixes on the codebasepriority: mediumif possible by the new releaseif possible by the new release