diff --git a/crayon/Runner/runner.py b/crayon/Runner/runner.py index 85d29c2..c3f2560 100644 --- a/crayon/Runner/runner.py +++ b/crayon/Runner/runner.py @@ -100,7 +100,29 @@ def to_jobs_local(runs: dict): output_path = tmpdir / name with tarfile.open(archive_path.resolve()) as tf: - tf.extractall(path=output_path.resolve()) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=output_path.resolve()) with (output_path / "agg_metrics.json").open("r") as fp: metrics = json.load(fp)