Fix PagingAndSortingRepository fails for Pageable.unpaged() (#255)

Author: upadhyaydhiren

src/main/java/com/arangodb/springframework/repository/SimpleArangoRepository.java

@@ -351,7 +351,7 @@ private <S extends T> ArangoCursor<T> findAllInternal(final Pageable pageable, @
 				buildFilterClause(example, bindVars), buildPageableClause(pageable, "e"));
 		arangoOperations.collection(domainClass);
 		return arangoOperations.query(query, bindVars,
-				pageable != null && pageable.isPaged() ? new AqlQueryOptions().fullCount(true) : null, domainClass);
+				pageable != null ? new AqlQueryOptions().fullCount(true) : null, domainClass);
 	}
 
 	private <S extends T> String buildFilterClause(final Example<S> example, final Map<String, Object> bindVars) {
@@ -366,7 +366,12 @@ private <S extends T> String buildFilterClause(final Example<S> example, final M
     private String buildPageableClause(final Pageable pageable, final String varName) {
         if (pageable == null) return "";
         Sort persistentSort = AqlUtils.toPersistentSort(pageable.getSort(), mappingContext, domainClass);
-        Pageable persistentPageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), persistentSort);
+		Pageable persistentPageable;
+		if (pageable.isPaged()) {
+			persistentPageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), persistentSort);
+		} else {
+			persistentPageable = pageable;
+		}
         return AqlUtils.buildPageableClause(persistentPageable, varName);
     }
 

src/test/java/com/arangodb/springframework/repository/ArangoRepositoryTest.java

@@ -13,12 +13,8 @@
 import java.util.Optional;
 
 import org.junit.Test;
-import org.springframework.data.domain.Example;
-import org.springframework.data.domain.ExampleMatcher;
+import org.springframework.data.domain.*;
 import org.springframework.data.domain.ExampleMatcher.StringMatcher;
-import org.springframework.data.domain.Page;
-import org.springframework.data.domain.PageRequest;
-import org.springframework.data.domain.Sort;
 
 import com.arangodb.springframework.testdata.Address;
 import com.arangodb.springframework.testdata.Customer;
@@ -515,4 +511,17 @@ public void exampleWithRefPropertyTest() {
 		assertEquals(customer, retrieved);
 	}
 
+	@Test
+	public void findAllUnpagedPageableTest() {
+		final List<Customer> toBeRetrieved = new LinkedList<>();
+		toBeRetrieved.add(new Customer("Dhiren", "Upadhyay", 30));
+		toBeRetrieved.add(new Customer("Ashim", "Upadhyay", 28));
+		toBeRetrieved.add(new Customer("Lokendr", "Upadhyay", 24));
+		repository.saveAll(toBeRetrieved);
+		final Page<Customer> retrievedPage = repository.findAll(Pageable.unpaged());
+		assertEquals(toBeRetrieved.size(), retrievedPage.getTotalElements());
+		assertEquals(toBeRetrieved.size(), retrievedPage.getSize());
+		assertEquals(toBeRetrieved, retrievedPage.getContent());
+	}
+
 }