fix: ruff fixes

dartpain · dartpain · commit 928e8588cab4 · 2026-04-15T22:38:22.000+01:00
diff --git a/tests/agents/test_workflow_agent_graph.py b/tests/agents/test_workflow_agent_graph.py
@@ -9,7 +9,6 @@
 from datetime import datetime, timezone
 from unittest.mock import MagicMock, patch
 
-import pytest
 
 
 def _make_agent(*, workflow_id=None, workflow=None, workflow_owner=None,
diff --git a/tests/agents/tools/test_brave_extra.py b/tests/agents/tools/test_brave_extra.py
@@ -2,7 +2,6 @@
 
 from unittest.mock import MagicMock, patch
 
-import pytest
 
 
 class TestBraveOptionalParams:
diff --git a/tests/agents/tools/test_internal_search_pg.py b/tests/agents/tools/test_internal_search_pg.py
@@ -3,7 +3,6 @@
 from contextlib import contextmanager
 from unittest.mock import patch
 
-import pytest
 
 
 @contextmanager
diff --git a/tests/agents/tools/test_notes_pg.py b/tests/agents/tools/test_notes_pg.py
@@ -3,7 +3,6 @@
 from contextlib import contextmanager
 from unittest.mock import patch
 
-import pytest
 
 
 @contextmanager
@@ -60,7 +59,6 @@ def test_not_pg_enabled_returns_error(self):
         assert "not configured" in msg
 
     def test_unknown_action(self, pg_conn):
-        import uuid as _uuid
         # Real tool_id requires a user_tools row
         from application.storage.db.repositories.user_tools import (
             UserToolsRepository,
@@ -76,7 +74,6 @@ def test_unknown_action(self, pg_conn):
 
 class TestNotesActionsMetadata:
     def test_returns_list(self):
-        from application.agents.tools.notes import NotesTool
         tool = _make_tool()
         got = tool.get_actions_metadata()
         assert isinstance(got, list)
diff --git a/tests/agents/tools/test_read_webpage_errors.py b/tests/agents/tools/test_read_webpage_errors.py
@@ -2,7 +2,6 @@
 
 from unittest.mock import patch
 
-import pytest
 import requests
 
 
diff --git a/tests/api/answer/routes/test_base.py b/tests/api/answer/routes/test_base.py
@@ -1,4 +1,5 @@
 import uuid
+from contextlib import contextmanager
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -319,8 +320,6 @@ def test_generates_error_stream(self, mock_mongo_db, flask_app):
 # Real-PG tests for check_usage against seeded agents + token usage
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-
 
 @contextmanager
 def _patch_base_db(conn):
diff --git a/tests/api/answer/routes/test_search.py b/tests/api/answer/routes/test_search.py
@@ -1,3 +1,4 @@
+from contextlib import contextmanager
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -255,8 +256,6 @@ class TestSearchEndpoint:
 # Real-PG tests for SearchResource.
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-
 
 @contextmanager
 def _patch_search_db(conn):
diff --git a/tests/api/answer/services/test_continuation_service_pg.py b/tests/api/answer/services/test_continuation_service_pg.py
@@ -2,9 +2,8 @@
 
 from contextlib import contextmanager
 from unittest.mock import patch
-from uuid import UUID, uuid4
+from uuid import uuid4
 
-import pytest
 
 
 @contextmanager
diff --git a/tests/api/answer/services/test_stream_processor_utils.py b/tests/api/answer/services/test_stream_processor_utils.py
@@ -5,7 +5,7 @@
 """
 
 from contextlib import contextmanager
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
 import pytest
 
diff --git a/tests/api/test_internal_routes.py b/tests/api/test_internal_routes.py
@@ -8,7 +8,6 @@
 from contextlib import contextmanager
 from unittest.mock import MagicMock, patch
 
-import pytest
 from flask import Flask
 
 
diff --git a/tests/api/user/agents/test_routes_happy.py b/tests/api/user/agents/test_routes_happy.py
@@ -1067,7 +1067,7 @@ def _broken():
 # ---------------------------------------------------------------------------
 
 
-class TestAdoptAgent:
+class TestAdoptAgentMore:
     def test_adopts_template_agent(self, app, pg_conn):
         from application.api.user.agents.routes import AdoptAgent
         from application.storage.db.repositories.agents import AgentsRepository
diff --git a/tests/api/user/agents/test_webhooks_gaps.py b/tests/api/user/agents/test_webhooks_gaps.py
@@ -5,8 +5,9 @@
 those collection objects so the tests run without pymongo installed.
 """
 
-from unittest.mock import Mock, patch
 import uuid
+from contextlib import contextmanager
+from unittest.mock import Mock, patch
 
 import pytest
 from flask import Flask
@@ -139,8 +140,6 @@ def test_enqueue_error_returns_500_with_message(self, app):
 # Real-PG tests for AgentWebhook (get) and AgentWebhookListener
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-
 
 @contextmanager
 def _patch_webhooks_db(conn):
diff --git a/tests/api/user/test_base.py b/tests/api/user/test_base.py
@@ -1,7 +1,7 @@
 import datetime
 import io
 from contextlib import contextmanager
-from unittest.mock import MagicMock, Mock, patch
+from unittest.mock import Mock, patch
 
 import pytest
 from werkzeug.datastructures import FileStorage
diff --git a/tests/api/user/test_tools_mcp_pg.py b/tests/api/user/test_tools_mcp_pg.py
@@ -103,7 +103,6 @@ def test_ssrf_url_raises(self):
     def test_valid_public_url_passes(self):
         from application.api.user.tools.mcp import _validate_mcp_server_url
         # Should not raise for a public-ish URL
-        from application.core.url_validation import SSRFError
         try:
             _validate_mcp_server_url({"server_url": "https://example.com/mcp"})
         except ValueError as e:
diff --git a/tests/api/user/test_tools_routes.py b/tests/api/user/test_tools_routes.py
@@ -1,5 +1,6 @@
 """Unit tests for application.api.user.tools.routes."""
 
+from contextlib import contextmanager
 from unittest.mock import Mock, patch
 
 import pytest
@@ -1034,9 +1035,6 @@ def test_returns_401_unauthenticated(self, app):
 # Happy-path tests using pg_conn
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-from unittest.mock import MagicMock
-
 
 @contextmanager
 def _patch_tools_db(conn):
diff --git a/tests/api/user/workflows/test_routes_coverage.py b/tests/api/user/workflows/test_routes_coverage.py
@@ -7,6 +7,7 @@
 """
 
 import uuid
+from contextlib import contextmanager
 from unittest.mock import Mock, patch
 
 import pytest
@@ -225,8 +226,6 @@ def test_delete_unauthorized(self, app):
 # Real-PG happy-path tests using pg_conn
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-
 
 @contextmanager
 def _patch_wf_db(conn):
@@ -756,8 +755,6 @@ def test_agent_node_invalid_schema_kept_original(self):
 class TestWriteGraphEdgesWithUnresolvedNodes:
     def test_drops_edge_with_unknown_source(self, pg_conn, app):
         from application.api.user.workflows.routes import (
-            WorkflowDetail,
-            WorkflowList,
             _write_graph,
         )
         from application.storage.db.repositories.workflows import (
diff --git a/tests/api/v1/test_routes_extended.py b/tests/api/v1/test_routes_extended.py
@@ -12,6 +12,9 @@
 """
 
 
+from contextlib import contextmanager
+from unittest.mock import MagicMock, patch
+
 import pytest
 from flask import Flask
 
@@ -175,9 +178,6 @@ def test_missing_auth_header_returns_401(self):
 # Tests using the ephemeral pg_conn fixture against real PG
 # ---------------------------------------------------------------------------
 
-from contextlib import contextmanager
-from unittest.mock import patch, MagicMock
-
 
 @contextmanager
 def _patch_v1_db(conn):
diff --git a/tests/storage/db/repositories/test_agent_folders.py b/tests/storage/db/repositories/test_agent_folders.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.agent_folders import AgentFoldersRepository
 
diff --git a/tests/storage/db/repositories/test_attachments.py b/tests/storage/db/repositories/test_attachments.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.attachments import AttachmentsRepository
 
diff --git a/tests/storage/db/repositories/test_attachments_extra.py b/tests/storage/db/repositories/test_attachments_extra.py
@@ -1,6 +1,5 @@
 """Extra tests for AttachmentsRepository covering remaining branches."""
 
-import pytest
 
 
 class TestResolveIds:
diff --git a/tests/storage/db/repositories/test_connector_sessions.py b/tests/storage/db/repositories/test_connector_sessions.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.connector_sessions import ConnectorSessionsRepository
 
diff --git a/tests/storage/db/repositories/test_connector_sessions_extra.py b/tests/storage/db/repositories/test_connector_sessions_extra.py
@@ -1,6 +1,5 @@
 """Extra tests for ConnectorSessionsRepository covering remaining branches."""
 
-import pytest
 
 
 class TestGetByUserAndProvider:
diff --git a/tests/storage/db/repositories/test_conversations.py b/tests/storage/db/repositories/test_conversations.py
@@ -4,7 +4,6 @@
 
 from datetime import datetime, timezone
 
-import pytest
 
 from application.storage.db.repositories.conversations import ConversationsRepository
 
diff --git a/tests/storage/db/repositories/test_memories.py b/tests/storage/db/repositories/test_memories.py
@@ -5,7 +5,6 @@
 
 from __future__ import annotations
 
-import pytest
 from sqlalchemy import text
 
 from application.storage.db.repositories.memories import MemoriesRepository
diff --git a/tests/storage/db/repositories/test_notes.py b/tests/storage/db/repositories/test_notes.py
@@ -5,7 +5,6 @@
 
 from __future__ import annotations
 
-import pytest
 from sqlalchemy import text
 
 from application.storage.db.repositories.notes import NotesRepository
diff --git a/tests/storage/db/repositories/test_pending_tool_state.py b/tests/storage/db/repositories/test_pending_tool_state.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.conversations import ConversationsRepository
 from application.storage.db.repositories.pending_tool_state import PendingToolStateRepository
diff --git a/tests/storage/db/repositories/test_prompts.py b/tests/storage/db/repositories/test_prompts.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.prompts import PromptsRepository
 
diff --git a/tests/storage/db/repositories/test_shared_conversations.py b/tests/storage/db/repositories/test_shared_conversations.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.conversations import ConversationsRepository
 from application.storage.db.repositories.shared_conversations import SharedConversationsRepository
diff --git a/tests/storage/db/repositories/test_sources.py b/tests/storage/db/repositories/test_sources.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.sources import SourcesRepository
 
diff --git a/tests/storage/db/repositories/test_stack_logs.py b/tests/storage/db/repositories/test_stack_logs.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 from sqlalchemy import text
 
 from application.storage.db.repositories.stack_logs import StackLogsRepository
diff --git a/tests/storage/db/repositories/test_todos.py b/tests/storage/db/repositories/test_todos.py
@@ -5,7 +5,6 @@
 
 from __future__ import annotations
 
-import pytest
 from sqlalchemy import text
 
 from application.storage.db.repositories.todos import TodosRepository
diff --git a/tests/storage/db/repositories/test_user_logs.py b/tests/storage/db/repositories/test_user_logs.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.user_logs import UserLogsRepository
 
diff --git a/tests/storage/db/repositories/test_users.py b/tests/storage/db/repositories/test_users.py
@@ -6,7 +6,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.users import UsersRepository
 
diff --git a/tests/storage/db/repositories/test_workflow_edges.py b/tests/storage/db/repositories/test_workflow_edges.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.workflows import WorkflowsRepository
 from application.storage.db.repositories.workflow_nodes import WorkflowNodesRepository
diff --git a/tests/storage/db/repositories/test_workflow_nodes.py b/tests/storage/db/repositories/test_workflow_nodes.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.workflows import WorkflowsRepository
 from application.storage.db.repositories.workflow_nodes import WorkflowNodesRepository
diff --git a/tests/storage/db/repositories/test_workflow_runs.py b/tests/storage/db/repositories/test_workflow_runs.py
@@ -4,7 +4,6 @@
 
 from datetime import datetime, timezone
 
-import pytest
 
 from application.storage.db.repositories.workflows import WorkflowsRepository
 from application.storage.db.repositories.workflow_runs import WorkflowRunsRepository
diff --git a/tests/storage/db/repositories/test_workflows.py b/tests/storage/db/repositories/test_workflows.py
@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import pytest
 
 from application.storage.db.repositories.workflows import WorkflowsRepository
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`
`3`	`3`	`from unittest.mock import MagicMock, patch`
`4`	`4`
`5`		`-import pytest`
`6`	`5`
`7`	`6`
`8`	`7`	`class TestBraveOptionalParams:`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`
`3`	`3`	`from unittest.mock import patch`
`4`	`4`
`5`		`-import pytest`
`6`	`5`	`import requests`
`7`	`6`
`8`	`7`