fix: errors

Author: dartpain

application/api/user/attachments/routes.py

@@ -86,6 +86,12 @@ def _enforce_uploaded_audio_size_limit(file, filename: str) -> None:
         enforce_audio_file_size_limit(size_bytes)
 
 
+def _get_store_attachment_user_error(exc: Exception) -> str:
+    if isinstance(exc, AudioFileTooLargeError):
+        return build_stt_file_size_limit_message()
+    return "Failed to process file"
+
+
 def _require_live_stt_redis():
     redis_client = get_redis_instance()
     if redis_client:
@@ -176,7 +182,7 @@ def post(self):
                     errors.append({
                         "upload_index": idx,
                         "filename": file.filename,
-                        "error": str(file_err)
+                        "error": _get_store_attachment_user_error(file_err),
                     })
 
             if not tasks:
@@ -473,12 +479,27 @@ def post(self):
             if not session_state.get("language") and transcript.get("language"):
                 session_state["language"] = transcript["language"]
 
-            apply_live_stt_hypothesis(
-                session_state,
-                str(transcript.get("text", "")),
-                chunk_index,
-                is_silence=is_silence,
-            )
+            try:
+                apply_live_stt_hypothesis(
+                    session_state,
+                    str(transcript.get("text", "")),
+                    chunk_index,
+                    is_silence=is_silence,
+                )
+            except ValueError:
+                current_app.logger.warning(
+                    "Invalid live transcription chunk",
+                    exc_info=True,
+                )
+                return make_response(
+                    jsonify(
+                        {
+                            "success": False,
+                            "message": "Invalid live transcription chunk",
+                        }
+                    ),
+                    409,
+                )
             save_live_stt_session(redis_client, session_state)
 
             return make_response(
@@ -505,11 +526,6 @@ def post(self):
                 ),
                 200,
             )
-        except ValueError as err:
-            return make_response(
-                jsonify({"success": False, "message": str(err)}),
-                409,
-            )
         except Exception as err:
             current_app.logger.error(
                 f"Error transcribing live audio chunk: {err}", exc_info=True

tests/api/user/attachments/test_routes.py

@@ -76,6 +76,7 @@ def save_file(file, path):
                 assert _get_response_status(response) == 200
                 assert [task["upload_index"] for task in payload["tasks"]] == [0, 2]
                 assert payload["errors"][0]["upload_index"] == 1
+                assert payload["errors"][0]["error"] == "Failed to process file"
 
     @patch("application.api.user.tasks.store_attachment.delay")
     @patch("application.stt.upload_limits.settings")
@@ -380,3 +381,57 @@ def test_live_stt_chunk_rejects_missing_session(
 
             assert _get_response_status(response) == 404
             assert _get_response_json(response)["message"] == "Live transcription session not found"
+
+    @patch("application.api.user.attachments.routes.STTCreator.create_stt")
+    @patch("application.api.user.attachments.routes.get_redis_instance")
+    def test_live_stt_chunk_hides_internal_value_errors(
+        self, mock_get_redis, mock_create_stt, flask_app, mock_mongo_db
+    ):
+        from application.api.user.attachments.routes import (
+            LiveSpeechToTextChunk,
+            LiveSpeechToTextStart,
+        )
+
+        app = Flask(__name__)
+        fake_redis = FakeRedis()
+        mock_get_redis.return_value = fake_redis
+
+        start_resource = LiveSpeechToTextStart()
+        with app.test_request_context(
+            "/api/stt/live/start",
+            method="POST",
+            json={"language": "ru"},
+        ):
+            request.decoded_token = {"sub": "test_user"}
+            start_response = start_resource.post()
+            session_id = _get_response_json(start_response)["session_id"]
+
+        mock_stt = MagicMock()
+        mock_stt.transcribe.return_value = {
+            "text": "hello there",
+            "language": "ru",
+            "duration_s": 1.0,
+            "segments": [],
+            "provider": "openai",
+        }
+        mock_create_stt.return_value = mock_stt
+
+        chunk_resource = LiveSpeechToTextChunk()
+        with app.test_request_context(
+            "/api/stt/live/chunk",
+            method="POST",
+            data={
+                "session_id": session_id,
+                "chunk_index": "-1",
+                "file": (io.BytesIO(b"chunk-neg"), "chunk-neg.wav"),
+            },
+            content_type="multipart/form-data",
+        ):
+            request.decoded_token = {"sub": "test_user"}
+            response = chunk_resource.post()
+
+            assert _get_response_status(response) == 409
+            assert (
+                _get_response_json(response)["message"]
+                == "Invalid live transcription chunk"
+            )