Skip to content

Commit 171a851

Browse files
committed
Remove all volatiles in PulseAudio player
These were probably never necessary in the first place, but they're even less necessary now that there's proper locking around everything.
1 parent 1d682ae commit 171a851

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/audio_player_pulse.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,20 +171,20 @@ class PulseAudioPlayer final : public AudioPlayer {
171171
float volume = 1.f;
172172
bool is_playing = false;
173173

174-
volatile unsigned long start_frame = 0;
175-
volatile unsigned long cur_frame = 0;
176-
volatile unsigned long end_frame = 0;
174+
unsigned long start_frame = 0;
175+
unsigned long cur_frame = 0;
176+
unsigned long end_frame = 0;
177177

178178
unsigned long bpf = 0; // bytes per frame
179179

180-
volatile int stream_success_val;
180+
int stream_success_val;
181181

182182
PAThreadedMainloop mainloop; // pulseaudio mainloop handle
183183
PAContext context; // connection context
184184

185185
PAStream stream;
186186

187-
volatile pa_usec_t play_start_time; // timestamp when playback was started
187+
pa_usec_t play_start_time; // timestamp when playback was started
188188

189189
/// Called by PA to notify about other context-related stuff
190190
static void PAContextNotifyCB(pa_context *c, pa_threaded_mainloop *mainloop);

0 commit comments

Comments
 (0)