Skip to content

Commit 8e1cd90

Browse files
committed
Stop trusting GetBestTranslation()
This started returning weird languages in some cases, like returning "ja" when a user has their system set to Windows but also has a Japanese language pack installed for e.g. a Japanese keyboard (even if it's not enabled by default). This will result in Aegisub always asking the user to pick a language on first startup, but that's probably better anyway.
1 parent 39ac32e commit 8e1cd90

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

src/aegisublocale.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,6 @@ bool AegisubLocale::HasLanguage(std::string const& language) {
7979
}
8080

8181
std::string AegisubLocale::PickLanguage() {
82-
if (active_language.empty()) {
83-
wxString os_ui_language = GetTranslations()->GetBestTranslation(AEGISUB_CATALOG);
84-
if (!os_ui_language.empty())
85-
return from_wx(os_ui_language);
86-
}
87-
8882
wxArrayString langs = GetTranslations()->GetAvailableTranslations(AEGISUB_CATALOG);
8983

9084
// No translations available, so don't bother asking the user

0 commit comments

Comments
 (0)