You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have no idea what the person who created the combine_karaoke method was thinking. To me, the previous results make no sense, so I changed its behavior to match what I think it should do. I have listed many examples to show what I think the result should be.
Example 1 - The line has no collision and the timing of the second line is after the first line:
Join (as karaoke)
Does the inverse of Split (by karaoke), i.e. the same as Join (concatenate) but inserts \k tags with the timing of each source line in the joined line.
Split (by karaoke)
Splits the line into one new line per syllable, as delimited by karaoke override tags (\k and its relatives). The timing of the first line will start at the original line’s start time and end at that time plus the length of the first syllable; the following lines will start at the end of the previous and last for the duration of the syllable.
So, I guess Join (as karaoke) isn't suppose to do what I want.
Should I modify Join (concatenate) and detect if the second line has a \k, \kf, \K or \ko, then I do what I was thinking?
Edit: If I do that, it will also resolve #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves: Ristellise/AegisubDC#36
I have no idea what the person who created the
combine_karaokemethod was thinking. To me, the previous results make no sense, so I changed its behavior to match what I think it should do. I have listed many examples to show what I think the result should be.Example 1 - The line has no collision and the timing of the second line is after the first line:
Before this PR (different k-time compared to the two lines):
After this PR (same k-time)
Example 2 - Lines have timing collision:
Before this PR (different k-time compared to the two lines):
After this PR (same k-time)
Example 3 - The line has no collision and the timing of the first line is after the second line:
Before this PR (different k-time compared to the two lines):
After this PR (different k-time compared to the two lines):
But, please note that
Join (concatenate)also doesn't work in this third case!