Skip to content

Support XDG Base Directory specification on Linux - #160

Open
witchymary wants to merge 3 commits into
arch1t3cht:featurefrom
witchymary:xdg-feature
Open

Support XDG Base Directory specification on Linux#160
witchymary wants to merge 3 commits into
arch1t3cht:featurefrom
witchymary:xdg-feature

Conversation

@witchymary

@witchymary witchymary commented Sep 15, 2024

Copy link
Copy Markdown

I simply fixed merge conflicts and compilation issues from wangqr#132. Closes #122. Here's the original description by @WhiredPlanck:

This PR will fix Issue Aegisub#226. Inspired by or adapted from aria2/aria2@8bc1d37 and Aegisub#148.

My basic idea just is:

* If `$HOME/.aegisub` exists, then the program will still read/write config/cache/data from there;

* If `$HOME/.aegisub` doesn't exist, then the program will read/write config/cache/data from corresponding XDG Base Directory.

I think this idea may need more optimization, but I just pull a request first so we could discuss the detail.

@witchymary

witchymary commented Sep 15, 2024

Copy link
Copy Markdown
Author

Note, this currently breaks DependencyControl due to https://github.com/TypesettingTools/DependencyControl/blob/master/modules/DependencyControl/Record.moon#L44. A fix would be to simply undo this small excerpt, but that kinda defies the point of the PR.

-	auto path_log = config::path->Decode("?user/log/");
+	auto path_log = config::path->Decode("?state/log/");

@heinrich5991

Copy link
Copy Markdown

@line0

line0 commented Aug 2, 2026

Copy link
Copy Markdown

Note, this currently breaks DependencyControl due to https://github.com/TypesettingTools/DependencyControl/blob/master/modules/DependencyControl/Record.moon#L44. A fix would be to simply undo this small excerpt, but that kinda defies the point of the PR.

-	auto path_log = config::path->Decode("?user/log/");
+	auto path_log = config::path->Decode("?state/log/");

Support added in TypesettingTools/DependencyControl#36.
Was that the only issue holding up this PR or do you expect any changes I should hold back on merging the DepCtrl PR for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add XDG Base Directory specification support

4 participants