Skip to content
This repository was archived by the owner on Dec 30, 2024. It is now read-only.

Commit 5ae2fbd

Browse files
committed
drop unsafe bytes to str conv
1 parent dd4d17f commit 5ae2fbd

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

writer.go

+4-9
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"io"
77
"net/http"
88
"time"
9-
"unsafe"
109

1110
"github.com/buger/jsonparser"
1211
"github.com/getsentry/sentry-go"
@@ -147,17 +146,17 @@ func (w *Writer) parseLogEvent(data []byte) (*sentry.Event, bool) {
147146
}
148147

149148
err := jsonparser.ObjectEach(data, func(key, value []byte, vt jsonparser.ValueType, offset int) error {
150-
switch string(key) {
149+
switch strKey := string(key); strKey {
151150
case zerolog.MessageFieldName:
152-
event.Message = bytesToStrUnsafe(value)
151+
event.Message = string(value)
153152
case zerolog.ErrorFieldName:
154153
event.Exception = append(event.Exception, sentry.Exception{
155-
Value: bytesToStrUnsafe(value),
154+
Value: string(value),
156155
Stacktrace: newStacktrace(),
157156
})
158157
case zerolog.LevelFieldName, zerolog.TimestampFieldName:
159158
default:
160-
event.Extra[string(key)] = bytesToStrUnsafe(value)
159+
event.Extra[strKey] = string(value)
161160
}
162161

163162
return nil
@@ -202,10 +201,6 @@ outer:
202201
return st
203202
}
204203

205-
func bytesToStrUnsafe(data []byte) string {
206-
return *(*string)(unsafe.Pointer(&data))
207-
}
208-
209204
// WriterOption configures sentry events writer.
210205
type WriterOption interface {
211206
apply(*config)

0 commit comments

Comments
 (0)