Skip to content

Commit 5da7fa8

Browse files
committed
treewide: reduce line length to 118
1 parent 8d495d4 commit 5da7fa8

File tree

17 files changed

+57
-23
lines changed

17 files changed

+57
-23
lines changed

devel/management/commands/archweb_inotify.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ def run():
7171
retry = False
7272
except OperationalError as exc:
7373
retry_count += 1
74-
logger.error('Unable to update database \'%s\', retrying=%d', self.path, retry_count, exc_info=exc)
74+
logger.error('Unable to update database \'%s\', retrying=%d',
75+
self.path, retry_count, exc_info=exc)
7576
time.sleep(5)
7677

7778
if retry_count == self.retry_limit:

devel/management/commands/readlinks_inotify.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ def setup_notifier(self):
8989
for name in all_paths:
9090
manager.add_watch(name, mask)
9191

92-
handler = EventHandler(arch_paths=arch_path_map, filename_suffix='.links.tar.gz', callback_func=wrapper_read_links)
92+
handler = EventHandler(arch_paths=arch_path_map,
93+
filename_suffix='.links.tar.gz',
94+
callback_func=wrapper_read_links)
9395
return pyinotify.Notifier(manager, handler)
9496

9597

devel/management/commands/reporead.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,9 @@ def parse_info(pkgname, filename, iofile):
539539
elif blockname:
540540
store[blockname].append(line)
541541
else:
542-
raise Exception("%s: Read package info outside a block while reading from %s: %s" % (pkgname, filename, line))
542+
raise Exception("%s: Read package info outside a block while reading from %s: %s" % (pkgname,
543+
filename,
544+
line))
543545
return store
544546

545547

devel/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# -*- coding: utf-8 -*-
22
import zoneinfo
3+
34
from django.contrib.auth.models import Group, User
45
from django.core.validators import MaxValueValidator, MinValueValidator
56
from django.db import models

devel/reports.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,8 @@ def non_existing_dependencies(packages):
202202

203203

204204
def non_reproducible_packages(packages):
205-
statuses = RebuilderdStatus.objects.select_related().filter(status=RebuilderdStatus.BAD, pkg__pkgname__in=packages.values('pkgname'))
205+
statuses = RebuilderdStatus.objects.select_related().filter(status=RebuilderdStatus.BAD,
206+
pkg__pkgname__in=packages.values('pkgname'))
206207
return linkify_non_reproducible_packages(statuses)
207208

208209

@@ -227,7 +228,7 @@ def orphan_dependencies(packages):
227228
JOIN packages_packagerelation ppr ON pp.pkgbase = ppr.pkgbase
228229
JOIN (SELECT DISTINCT cp.pkgname FROM packages cp LEFT JOIN packages_packagerelation pr ON cp.pkgbase = pr.pkgbase WHERE pr.id IS NULL) child ON ppd.name = child.pkgname
229230
ORDER BY child.pkgname;
230-
"""
231+
""" # noqa: E501
231232
cursor.execute(query)
232233

233234
for row in cursor.fetchall():

devel/views.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,9 @@ def tier0_mirror_auth(request):
216216
token = credentials[1]
217217

218218
groups = Group.objects.filter(name__in=SELECTED_GROUPS)
219-
user = User.objects.filter(username=username, is_active=True, groups__in=groups).select_related('userprofile').first()
219+
user = User.objects.filter(username=username,
220+
is_active=True,
221+
groups__in=groups).select_related('userprofile').first()
220222
if not user:
221223
return unauthorized
222224

main/storage.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
import cssmin
21
import jsmin
32
from django.contrib.staticfiles.storage import ManifestStaticFilesStorage
43
from django.core.files.base import ContentFile
54
from django.utils.encoding import smart_str
65

6+
import cssmin
7+
78

89
class MinifiedStaticFilesStorage(ManifestStaticFilesStorage):
910
"""

main/templatetags/pgp.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def pgp_dev_key_link(key_id):
3535
key_id = pad_key_id(key_id)
3636
if not key_id:
3737
return "Unknown"
38-
link_text = (''.join((f'<span>{key_id[i:i+4]}</span>' for i in range(0, len(key_id), 4))))
38+
link_text = (''.join((f'<span>{key_id[i:i + 4]}</span>' for i in range(0, len(key_id), 4))))
3939
link_text = f'<div class="pgp-key-ids">{link_text}</div>'
4040
return pgp_key_link(key_id, link_text)
4141

@@ -51,7 +51,9 @@ def pgp_key_link(key_id, link_text=None):
5151
return format_key(key_id)
5252
pgp_server_secure = getattr(settings, 'PGP_SERVER_SECURE', False)
5353
scheme = 'https' if pgp_server_secure else 'http'
54-
url = '%s://%s/pks/lookup?op=vindex&amp;fingerprint=on&amp;exact=on&amp;search=0x%s' % (scheme, pgp_server, key_id)
54+
url = '%s://%s/pks/lookup?op=vindex&amp;fingerprint=on&amp;exact=on&amp;search=0x%s' % (scheme,
55+
pgp_server,
56+
key_id)
5557
if link_text is None:
5658
link_text = '0x%s' % key_id[-8:]
5759
values = (url, format_key(key_id), link_text)

news/views.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@ def form_valid(self, form):
5454
if settings.MAILMAN_PASSWORD:
5555
headers['Approved'] = settings.MAILMAN_PASSWORD
5656
template = loader.get_template('news/news_email_notification.txt')
57+
author = newsitem.author.get_full_name()
58+
from_ = f'"Arch Linux: Recent news updates: {author}" <{settings.ANNOUNCE_EMAIL}>'
5759
EmailMessage(
5860
subject=f'[arch-announce] {newsitem.title}',
5961
body=template.render(ctx),
60-
from_email=f'"Arch Linux: Recent news updates: {newsitem.author.get_full_name()}" <{settings.ANNOUNCE_EMAIL}>',
62+
from_email=from_,
6163
to=[settings.ANNOUNCE_EMAIL],
6264
headers=headers).send()
6365
return super(NewsCreateView, self).form_valid(form)

packages/management/commands/populate_signoffs.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ def create_specification(package, log, finder):
5353

5454

5555
def get_tag_info(repo, pkgbase, version):
56-
# Gitlab requires the path to the gitlab repo to be html encoded and project name encoded in a different special way
56+
# Gitlab requires the path to the gitlab repo to be html encoded and
57+
# project name encoded in a different special way
5758
pkgrepo = urllib.parse.quote_plus(f'{settings.GITLAB_PACKAGE_REPO}/') + gitlab_project_name_to_path(pkgbase)
5859
url = f'https://{settings.GITLAB_INSTANCE}/api/v4/projects/{pkgrepo}/repository/tags'
5960

@@ -112,7 +113,8 @@ def cleanup_signoff_comments():
112113
id_signoffs = [signoff.id for g in groups for signoff in g.signoffs]
113114
logger.info("Keeping %s signoffs", len(id_signoffs))
114115
# FakeSignoffSpecification's have no id
115-
id_signoffspecs = [g.specification.id for g in groups if not isinstance(g.specification, FakeSignoffSpecification)]
116+
id_signoffspecs = [g.specification.id for g in groups if not isinstance(g.specification,
117+
FakeSignoffSpecification)]
116118
logger.info("Keeping %s signoffspecifications", len(id_signoffspecs))
117119

118120
Signoff.objects.exclude(id__in=id_signoffs).delete()

packages/models.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,8 @@ def log_update(self, old_pkg, new_pkg):
253253
if new_pkg:
254254
update.action_flag = CHANGE
255255
# ensure we should even be logging this
256-
if old_pkg.pkgver == new_pkg.pkgver and old_pkg.pkgrel == new_pkg.pkgrel and old_pkg.epoch == new_pkg.epoch:
256+
if old_pkg.pkgver == new_pkg.pkgver and old_pkg.pkgrel == new_pkg.pkgrel \
257+
and old_pkg.epoch == new_pkg.epoch:
257258
# all relevant fields were the same; e.g. a force update
258259
return
259260
else:
@@ -395,7 +396,8 @@ def get_best_satisfier(self):
395396
# actually satisfy the requirements
396397
if self.comparison and self.version:
397398
alpm = AlpmAPI()
398-
pkgs = [pkg for pkg in pkgs if not alpm.available or alpm.compare_versions(pkg.full_version, self.comparison, self.version)]
399+
pkgs = [pkg for pkg in pkgs if not alpm.available or alpm.compare_versions(pkg.full_version,
400+
self.comparison, self.version)]
399401
if len(pkgs) == 0:
400402
# couldn't find a package in the DB
401403
# it should be a virtual depend (or a removed package)

packages/views/__init__.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,14 @@ def sonames(request):
140140
name = request.GET.get('name')
141141

142142
if name:
143-
sonames = Soname.objects.filter(name__startswith=name).values('pkg__pkgname', 'pkg__pkgver', 'pkg__pkgrel', 'pkg__epoch', 'pkg__repo__name')
144-
packages = [{'pkgname': soname['pkg__pkgname'], 'pkgrel': soname['pkg__pkgrel'], 'pkgver': soname['pkg__pkgver'], 'epoch': soname['pkg__epoch'], 'repo': soname['pkg__repo__name'].lower()} for soname in sonames]
143+
sonames = Soname.objects.filter(name__startswith=name).values('pkg__pkgname',
144+
'pkg__pkgver',
145+
'pkg__pkgrel',
146+
'pkg__epoch',
147+
'pkg__repo__name')
148+
packages = [{'pkgname': soname['pkg__pkgname'], 'pkgrel': soname['pkg__pkgrel'],
149+
'pkgver': soname['pkg__pkgver'], 'epoch': soname['pkg__epoch'],
150+
'repo': soname['pkg__repo__name'].lower()} for soname in sonames]
145151
else:
146152
return HttpResponseBadRequest('name parameter is required')
147153

packages/views/flag.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ def clean_message(self):
3838
# make sure the message isn't garbage (only punctuation or whitespace)
3939
# or spam (using a simple denylist)
4040
# and ensure a certain minimum length
41-
if re.match(r'^[^0-9A-Za-z]+$', data) or any(fd.keyword in data for fd in FlagDenylist.objects.all()) or len(data) < 3:
41+
if re.match(r'^[^0-9A-Za-z]+$', data) or any(fd.keyword in data for fd in FlagDenylist.objects.all()) \
42+
or len(data) < 3:
4243
raise forms.ValidationError("Enter a valid and useful out-of-date message.")
4344
return data
4445

public/views.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,9 @@ def feeds(request):
9292
@cache_control(max_age=307)
9393
def keys(request):
9494
profile_ids = UserProfile.allowed_repos.through.objects.values('userprofile_id')
95-
users = User.objects.filter(
96-
is_active=True, userprofile__id__in=profile_ids).order_by('first_name', 'last_name').select_related('userprofile')
95+
users = User.objects.filter(is_active=True,
96+
userprofile__id__in=profile_ids).order_by('first_name',
97+
'last_name').select_related('userprofile')
9798
user_key_ids = frozenset(user.userprofile.pgp_key[-16:] for user in users
9899
if user.userprofile.pgp_key)
99100

releng/urls.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
releases_patterns = [
1010
path('', ReleaseListView.as_view(), name='releng-release-list'),
1111
path('json/', views.releases_json, name='releng-release-list-json'),
12-
re_path(r'^(?P<version>[-.\w]+)/$', cache_page(311)(ReleaseDetailView.as_view()), name='releng-release-detail'),
13-
re_path(r'^(?P<version>[-.\w]+)/torrent/$', cache_page(311)(views.release_torrent), name='releng-release-torrent'),
12+
re_path(r'^(?P<version>[-.\w]+)/$', cache_page(311)(ReleaseDetailView.as_view()),
13+
name='releng-release-detail'),
14+
re_path(r'^(?P<version>[-.\w]+)/torrent/$', cache_page(311)(views.release_torrent),
15+
name='releng-release-torrent'),
1416
]
1517

1618
netboot_patterns = [

ruff.toml

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ select = [
2424
]
2525

2626
ignore = [
27-
"E501", # line lengt violation
2827
"E731", # Do not assign a `lambda` expression, use a `def`
2928
"B904", # Within an `except` clause, raise exceptions with `raise ... from err`
3029
"RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
@@ -34,3 +33,8 @@ ignore = [
3433
"DJ008", # Model does not define `__str__` method
3534
"DJ012", # Order of model's inner classes, methods, and fields does not follow the Django Style Guide: `Meta` class should come before `get_absolute_url`
3635
]
36+
37+
# Ignore Django migrations
38+
exclude = [
39+
"*/migrations/*.py"
40+
]

settings.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,9 @@
266266
INSTALLED_APPS = [*list(INSTALLED_APPS), 'debug_toolbar']
267267

268268
if PROMETHEUS_METRICS:
269-
MIDDLEWARE = ['django_prometheus.middleware.PrometheusBeforeMiddleware', *list(MIDDLEWARE), 'django_prometheus.middleware.PrometheusAfterMiddleware']
269+
MIDDLEWARE = ['django_prometheus.middleware.PrometheusBeforeMiddleware',
270+
*list(MIDDLEWARE),
271+
'django_prometheus.middleware.PrometheusAfterMiddleware']
270272

271273
INSTALLED_APPS = [*list(INSTALLED_APPS), 'django_prometheus']
272274

0 commit comments

Comments
 (0)