Not only does getFormattedTime() not give the date, the time is often invalid, because the digits for minutes are reversed!
I get for example: 06:75, 06:85, 06:95 instead of 06:57, 06:58, 06:59!

On Arduino 1.8.15/ESP32 v2.0.0-rc-1
It could be a problem with the String() constructor from unsigned long, because I don't see anything weird in your code.

Indeed it is. Look at the output of this code:

void setup() {
  Serial.begin(115200);
  delay(100);
    
  for(unsigned long ul = 0; ul < 60; ul++) {
    Serial.println(String(ul)); 
  }
}

void loop() {
}

it prints:

It's hilarious! I will post it on the ESP32 thread (if not already done so)

The problem can be fixed in your getFormattedTime() code to change the type of the variables hours, minutes and seconds from unsigned long to unsigned short, which is more than enough for those values [0-59].

String NTPClient::getFormattedTime() const {
  unsigned long rawTime = this->getEpochTime();
  unsigned short hours = (rawTime % 86400L) / 3600;
  String hoursStr = hours < 10 ? "0" + String(hours) : String(hours);

  unsigned short minutes = (rawTime % 3600) / 60;
  String minuteStr = minutes < 10 ? "0" + String(minutes) : String(minutes);

  unsigned short seconds = rawTime % 60;
  String secondStr = seconds < 10 ? "0" + String(seconds) : String(seconds);

  return hoursStr + ":" + minuteStr + ":" + secondStr;
}

getFormattedTime does not give date+time string #139

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions