-
Notifications
You must be signed in to change notification settings - Fork 279
Open
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
Support for the Arduino Nano ESP32 board was added to the library:
However, the esp32 architecture identifier has not been added to the architectures property in the library's library.properties metadata file:
Line 9 in c2936a2
| architectures=avr,megaavr,sam,samd,nrf52,stm32f4,mbed,mbed_nano,mbed_portenta,mbed_rp2040,renesas,renesas_portenta,renesas_uno,zephyr |
This causes a spurious warning to be displayed when compiling the library for the ESP32 board:
WARNING: library Servo claims to run on avr, megaavr, sam, samd, nrf52, stm32f4, mbed, mbed_nano, mbed_portenta, mbed_rp2040, renesas, renesas_portenta, renesas_uno, zephyr architecture(s) and may be incompatible with your current board which runs on esp32 architecture(s).
It could also result in incorrect library discovery under certain conditions, as architecture matching is a significant factor in the priority system:
https://arduino.github.io/arduino-cli/dev/sketch-build-process/#architecture-matching
Additional context
Related
Metadata
Metadata
Assignees
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project