Skip to content

Code Review - Please remove this from code #390

New issue
New issue
Open
Open
Code Review - Please remove this from code#390
Labels
topic: codeRelated to content of the project itselftype: enhancementProposed improvement
@ondra-novak

Description

@ondra-novak
ondra-novak
opened on Oct 29, 2024

This should be removed from code. Don't mix macros and C++. This code cannot pass my internal code review check.

ArduinoCore-renesas/libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h

Line 144 in 1169821

#define loadSequence(frames) loadWrapper(frames, sizeof(frames))

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic: codeRelated to content of the project itselftype: enhancementProposed improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions