fix: change prog_firehose_ddr.elf path to avoid qdl 2.4 errors on Windows (#73)

* Change prog_firehose path to avoid errors related to qdl 2.4 on Windows

* Do not prompt the user when flashing in gRPC mode

* Fix check to clean up the directory after a successful run

* Print message to make it clear that the flasher is checking if data preservation is possible

Author: MatteoPologruto

internal/updater/flasher.go

@@ -120,8 +120,11 @@ func FlashBoard(ctx context.Context, serialStr string, downloadedImagePath *path
 
 	rawProgram := "rawprogram0.xml"
 	if preserveUser {
+		feedback.Print(i18n.Tr("Checking if the OS version on the UNO Q supports data preservation. Please connect the board in EDL mode."))
 		if errT := checkBoardGPTTable(ctx, qdlPath, flashDir); errT == nil && flashDir.Join("rawprogram0.nouser.xml").Exist() {
 			rawProgram = "rawprogram0.nouser.xml"
+		} else if callback != nil {
+			return fmt.Errorf("it will not be possible to preserve the data: %w", errT)
 		} else {
 			res, err := func(target string) (bool, error) {
 				warnStr := "Linux image " + target + " does not support user partition preservation"
@@ -251,23 +254,26 @@ func installQdl() (*paths.Path, func(), error) {
 
 // Checks the board GPT table and counts the number of partitions, this tells if the board supports preserving or not user's data.
 func checkBoardGPTTable(ctx context.Context, qdlPath, flashDir *paths.Path) error {
-	dumpBinPath := qdlPath.Parent().Join("dump.bin")
+	dumpBinPath := flashDir.Join("dump.bin")
 	readXMLPath := qdlPath.Parent().Join("read.xml")
 	err := readXMLPath.WriteFile(artifacts.ReadXML)
 	if err != nil {
 		return err
 	}
-	cmd, err := paths.NewProcess(nil, qdlPath.String(), "--storage", "emmc", flashDir.Join("prog_firehose_ddr.elf").String(), readXMLPath.String())
+	cmd, err := paths.NewProcess(nil, qdlPath.String(), "--storage", "emmc", "prog_firehose_ddr.elf", readXMLPath.String())
 	if err != nil {
 		return err
 	}
-	cmd.SetDir(qdlPath.Parent().String())
+	cmd.SetDir(flashDir.String())
 	if err := cmd.RunWithinContext(ctx); err != nil {
 		return err
 	}
 	if !dumpBinPath.Exist() {
 		return fmt.Errorf("it was not possible to access the current Debian image GPT table")
 	}
+	defer func() {
+		_ = dumpBinPath.Remove()
+	}()
 	dump, err := dumpBinPath.ReadFile()
 	if err != nil {
 		return err

service/service_flash.go

@@ -62,7 +62,7 @@ func (s *flasherServerImpl) Flash(req *flasher.FlashRequest, stream flasher.Flas
 
 	tmpPath := paths.New(req.GetTempPath())
 	rmTempPath := func() {
-		if tmpPath.Exist() {
+		if tmpPath.IsDir() {
 			_ = tmpPath.RemoveAll()
 		}
 	}