[PC-1781]Updated datasheet links #1937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed old RA4M1 datasheet and replaced with most up to date version from Renesas website - Fixed links
There was a problem hiding this comment.
@pedromsousalima neither of the links work the way we intend. The first one shows the same issue as before, and the second leads to the GitHub source page instead of showing it on docs -> https://docs.arduino.cc/resources/datasheets/esp32-s3-mini.pdf
jhansson-ard
added
Datasheet
arduino
pedromsousalima
changed the title
jacobhylen
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Hello @pedromsousalima.
These changes are in themselves good, but there are some things that need addressing before we can merge it.
Left comments. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Removed old RA4M1 datasheet and replaced it with the most up-to-date version from Renesas website
Fixed links (one is using a fixed path and the other one is using a relative path but trying instead to look at a different directory level for testing reasons)
Contribution Guidelines