Merge branch '3.x' into bugfix/get-table

Author: ifox

Diff for: .github/workflows/main.yml

@@ -129,10 +129,6 @@ jobs:
         run: |
           npm ci
 
-      - name: Create blocks dir
-        run: |
-          mkdir ./frontend/js/components/blocks/customs
-
       - name: Build twill.
         run: ./vendor/bin/testbench twill:build --forTesting
         env:

Diff for: .github/workflows/release.yml

@@ -0,0 +1,61 @@
+name: Release
+
+on:
+  workflow_dispatch:
+    inputs:
+      version_bump_type:
+        description: 'Type of version bump (patch, minor, major)'
+        required: true
+        default: 'patch'
+
+jobs:
+  build-and-pr:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          ref: 3.x
+      
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Build project
+        run: npm run build
+
+      - name: Copy build artifacts
+        run: |
+          mkdir -p twill-assets/assets
+          rm -rf twill-assets/assets/*
+          cp -r dist/assets/* twill-assets/assets/
+
+      - name: Bump version
+        id: bump_version
+        run: |
+          npm version ${{ github.event.inputs.version_bump_type }} --no-git-tag-version
+          echo "::set-output name=new_version::$(node -p "require('./package.json').version")"
+      
+      - name: Update version in PHP file
+        run: |
+          NEW_VERSION="${{ steps.bump_version.outputs.new_version }}"
+          sed -i "s/\(public const VERSION = '\)[^']*\(';\)/\1${NEW_VERSION}\2/" src/TwillServiceProvider.php
+
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v5
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          commit-message: |
+            Update assets and bump version to ${{ steps.bump_version.outputs.new_version }}
+          title: |
+            Twill ${{ steps.bump_version.outputs.new_version }} release
+          body: |
+            This PR updates the build and bumps the version number to ${{ steps.bump_version.outputs.new_version }}.
+          branch: release-${{ steps.bump_version.outputs.new_version }}
+          base: 3.x

Diff for: CHANGELOG.md

@@ -2,6 +2,54 @@
 
 All notable changes to `twill` will be documented in this file.
 
+## 3.5.2
+
+### Fixed
+
+- Fix cropper regression (likely a from a recent browser update) by [@13twelve](https://github.com/13twelve) in [#2744](https://github.com/area17/twill/pull/2744)
+
+
+## 3.5.1
+
+### Fixed
+
+- Fix file library uploader regression by [@joyceverheije](https://github.com/joyceverheije) in https://github.com/area17/twill/pull/2740
+- Fix `timeOnly` variant of the `Datepicker` field by [@MamlukiSn](https://github.com/MamlukiSn) in https://github.com/area17/twill/pull/2739 
+
+### Improved
+
+- Add a warning during the `twill:update` and `twill:build` commands for developers that have `twill.load_default_migrations` set to false by [@ifox](https://github.com/ifox) in [de274175](https://github.com/area17/twill/commit/de274175)
+
+## 3.5.0
+
+### Added
+
+- Add a `ModuleController::setPreviewView()` method by @zachgarwood in https://github.com/area17/twill/pull/2724
+- Add a `disableCrop()` method to `medias` fields by @ifox in https://github.com/area17/twill/pull/2686
+
+### Fixed
+
+- Fix position management in `medias` and `files` fields by @zeezo887 in https://github.com/area17/twill/pull/2694
+- Fix issues with touch actions by @13twelve in https://github.com/area17/twill/pull/2713
+- Fix issue with `Relation` column by @zachgarwood in https://github.com/area17/twill/pull/2720
+- Fix endpoints initialization for `Browser` component by @zeezo887 in https://github.com/area17/twill/pull/2722
+- Fix image cropper for erroneous EXIF orientation: Use JS to read image dimensions on upload by @13twelve in https://github.com/area17/twill/pull/2705
+- Fix square crops having mismatching width/height values by @13twelve in https://github.com/area17/twill/pull/2706
+- Fix `hideActiveCrop()` not working for medias form field when max is greater than 1 by @zeezo887 in https://github.com/area17/twill/pull/2686
+- Fix #2641: `InlineRepeater` updates by @13twelve in https://github.com/area17/twill/pull/2714
+- Fix Vue dropdown console warnings: update useCapture param for removeEventListener to match addEventListener by @zeezo887 in https://github.com/area17/twill/pull/2687
+- Fix #2657: adds missing Vue draggable deprecations by @13twelve in https://github.com/area17/twill/pull/2707
+
+### Docs
+
+- Added instructions to disable publish switch in create modal by @ordigital in https://github.com/area17/twill/pull/2698
+- Added instructions for `MultiSelect` field with dynamic values in form builder by @ordigital in https://github.com/area17/twill/pull/2699
+- Added instructions for free cropping with `null` or `0` ratio value by @LucaRed in https://github.com/area17/twill/pull/2715
+
+### Translations
+
+- Fix #2619: adds missing iso languages by @13twelve in https://github.com/area17/twill/pull/2708
+
 ## 3.4.1
 
 ### Improved
@@ -66,6 +114,12 @@ All notable changes to `twill` will be documented in this file.
 - Bump body-parser and express by [@dependabot](https://github.com/dependabot) in https://github.com/area17/twill/pull/2659
 - Bump cookie and express by [@dependabot](https://github.com/dependabot) in https://github.com/area17/twill/pull/2664
 
+## 3.3.2
+ 
+### Fixed
+ 
+- Backport fix from 3.5.1: `timeOnly` variant of the `Datepicker` field by [@MamlukiSn](https://github.com/MamlukiSn) in https://github.com/area17/twill/pull/2739
+
 ## 3.3.1
 
 ### Fixed

Diff for: docs/content/1_docs/4_form-fields/11_repeater.md

@@ -29,15 +29,13 @@ Repeater::make()
 :::#tab:::
 :::#tabs:::
 
-| Option         | Description                                  | Type    | Default value    |
-|:---------------|:---------------------------------------------|:--------|:-----------------|
-| type           | Type of repeater items                       | string  |                  |
-| name           | Name of the field                            | string  | same as `type`   |
-| max            | Maximum amount that can be created           | number  | null (unlimited) |
-| buttonAsLink   | Displays the `Add` button as a centered link | boolean | false            |
-| disableCreate  | Disables ability to add new items            | boolean | true             |
-| disableActions | Removes row item actions                     | boolean | true             |
-| disableReorder | Disables reordering of repeater items        | boolean | true             |
+| Option       | Description                                  | Type    | Default value    |
+|:-------------|:---------------------------------------------|:--------|:-----------------|
+| type         | Type of repeater items                       | string  |                  |
+| name         | Name of the field                            | string  | same as `type`   |
+| max          | Maximum amount that can be created           | number  | null (unlimited) |
+| buttonAsLink | Displays the `Add` button as a centered link | boolean | false            |
+| reorder      | Allow reordering of repeater items           | boolean | true             |
 
 <br/>
 
@@ -165,6 +163,17 @@ class ProjectController extends BaseModuleController
 }
 ```
 
+| Option         | Description                                  | Type    | Default value    |
+|:---------------|:---------------------------------------------|:--------|:-----------------|
+| type           | Type of repeater items                       | string  |                  |
+| name           | Name of the field                            | string  | same as `type`   |
+| max            | Maximum amount that can be created           | number  | null (unlimited) |
+| buttonAsLink   | Displays the `Add` button as a centered link | boolean | false            |
+| disableCreate  | Disables ability to add new items            | boolean | false            |
+| disableActions | Removes row item actions                     | boolean | false            |
+| disableReorder | Disables reordering of repeater items        | boolean | false            |
+
+
 ## Blade repeater fields
 
 The following example demonstrates how to define a relationship between `Team` and `TeamMember` modules to implement

Diff for: docs/content/1_docs/7_media-library/03_role-crop-params.md

@@ -6,7 +6,7 @@ A _role_ is a way to define different contexts in which an image might be placed
 
 _Crops_ are more self-explanatory. Twill comes with some pre-defined crop settings to allow you to set different variants of a given image, so crops can be used in combination with _roles,_ or they can be used on their own with a single role to define multiple cropping ratios on the same image.
 
-Using the Person example, your `cover` image could have a `square` crop for mobile screens, but could use a `16/9` crop on larger screens. Those values are editable at your convenience for each model, even if there are already some crops created in the CMS.
+Using the Person example, your `cover` image could have a `square` crop for mobile screens, but could use a `16/9` crop on larger screens. Those values are editable at your convenience for each model in the `ratio` option, even if there are already some crops created in the CMS. By specifying `null` or `0` as a `ratio`, no automatic crop will happen and you'll be able to crop freely.
 
 The only thing you have to do to make it work is to compose your model and repository with the appropriate traits, respectively `HasMedias` and `HandleMedias`, set up your `$mediasParams` configuration and use the `medias` form partial in your form view (more info in the CRUD section).
 

Diff for: frontend/js/components/Cropper.vue

@@ -189,13 +189,12 @@
         //
         // from my testing it seems to be a little inconsistent and unpredictable
         // I guess you just need for the rounding error to happen
-        // But, it seems setting the properties individually avoids this...
+        // But, it seems re-setting the properties individually avoids this...
         //
         // -- Mike ([email protected])
+        this.cropper.setData(crop)
         this.cropper.setData({ x: crop.x })
         this.cropper.setData({ y: crop.y })
-        this.cropper.setData({ width: crop.width })
-        this.cropper.setData({ height: crop.height })
       },
       test: function () {
         const crop = this.toNaturalCrop({ x: 0, y: 0, width: 380, height: 475 })

Diff for: frontend/js/components/DatePicker.vue

@@ -132,7 +132,7 @@
           wrap: true,
           altInput: true,
           altFormat: self.altFormatComputed,
-          dateFormat: self.enableTime ? 'Z' : 'Y-m-d', // This is the universal format that will be parsed by the back-end.
+          dateFormat: (self.enableTime && self.noCalendar) ? 'H:i:S' : (self.enableTime ? 'Z' : 'Y-m-d'), // This is the universal format that will be parsed by the back-end.
           static: self.staticMode,
           appendTo: self.staticMode ? self.$refs[self.refs.flatPicker] : undefined,
           enableTime: self.enableTime,
@@ -217,7 +217,8 @@
       },
       isValidTime: function (string) {
         const timeRegex = /^(0?[1-9]|1[0-2]):[0-5][0-9](?: (AM|PM))?$/i;
-        return timeRegex.test(string);
+        const time24HrRegex = /^([01]\d|2[0-3]):[0-5]\d(?::[0-5]\d)?$/;
+        return timeRegex.test(string) || time24HrRegex.test(string);
       }
     },
     mounted: function () {

Diff for: frontend/js/components/blocks/customs/.keep

@@ -0,0 +1 @@
+

Diff for: frontend/js/components/media-library/Uploader.vue

@@ -197,53 +197,61 @@
         this.uploadProgress(0)
       },
       _onSubmitCallback (id, name) {
+        const file = this._uploader.methods.getFile(id)
+
+        if (!file.type.startsWith('image/')) {
+          this.prepareUpload(id, name)
+          return
+        }
+
         return new Promise((resolve, reject) => {
           // halt fine uploader upload until image is loaded
           // so we can send image dimensions with the upload
           const img = new Image()
           img.onload = () => {
-            this.$emit('clear')
-            // each upload session will add upload files with original filenames in a folder named using a uuid
-            this.unique_folder_name = this.unique_folder_name || (this.uploaderConfig.endpointRoot + qq.getUniqueId())
-
-            // determine the image dimensions and add it to params sent on upload success
-            this._uploader.methods.setParams({
+            this.prepareUpload(id, name, {
               width: img.width,
-              height: img.height,
-              unique_folder_name: this.unique_folder_name,
-              media_to_replace_id: this.media_to_replace_id
-            }, id)
-
-            this.media_to_replace_id = null
-
-            const media = {
-              id: this._uploader.methods.getUuid(id),
-              name: sanitizeFilename(name),
-              progress: 0,
-              error: false,
-              errorMessage: null,
-              isReplacement: !!this.media_to_replace_id,
-              replacementId: this.media_to_replace_id
-            }
-
-            if (this.type.value === 'file') {
-              this.media_to_replace_id = null
-            }
-
-            this.loadingMedias.push(media)
-            this.loadingProgress(media)
-
+              height: img.height
+            })
             // resolve the promise, allow the upload to continue
             resolve(img)
           }
-
           img.onerror = (err) => {
             console.error(err) // eslint-disable-line
-            reject(err);
+            reject(err)
           }
+          img.src = URL.createObjectURL(file)
+        })
+      },
+
+      prepareUpload(id, name, additionalParams = {}) {
+        this.$emit('clear')
+
+        // each upload session will place uploaded files with original
+        // filenames in a single folder named using a uuid
+        this.unique_folder_name = this.unique_folder_name ||
+          (this.uploaderConfig.endpointRoot + qq.getUniqueId())
+
+        this._uploader.methods.setParams({
+          unique_folder_name: this.unique_folder_name,
+          media_to_replace_id: this.media_to_replace_id,
+          ...additionalParams
+        }, id)
+
+        const media = {
+          id: this._uploader.methods.getUuid(id),
+          name: sanitizeFilename(name),
+          progress: 0,
+          error: false,
+          errorMessage: null,
+          isReplacement: !!this.media_to_replace_id,
+          replacementId: this.media_to_replace_id
+        }
+
+        this.media_to_replace_id = null
 
-          img.src = URL.createObjectURL(this._uploader.methods.getFile(id))
-        });
+        this.loadingMedias.push(media)
+        this.loadingProgress(media)
       },
       _onProgressCallback (id, name, uploadedBytes, totalBytes) {
         const index = this.loadingMedias.findIndex((m) => m.id === this._uploader.methods.getUuid(id))