ItemNotFoundException Thrown for Newly Created Settings Until First Access

[abidkhan484]

Description

Newly created settings throw an ItemNotFoundException if they haven’t been accessed at least once after creation.

Steps to reproduce

1. Create a new settings blade file. e.g: resources/views/twill/settings/site-settings/hubspot.blade.php
2. Without accessing the settings page, visit any content

Expected result

It should handle the data accordingly.

Actual result

It's currently returning the below error.

[previous exception] [object] (Illuminate\\Support\\ItemNotFoundException(code: 0):  at /var/www/html/vendor/laravel/framework/src/Illuminate/Collections/Collection.php:1433)

[stacktrace]

#0 /var/www/html/vendor/area17/twill/src/TwillAppSettings.php(111): Illuminate\\Support\\Collection->firstOrFail()

#1 /var/www/html/vendor/area17/twill/src/TwillAppSettings.php(68): A17\\Twill\\TwillAppSettings->getGroupDataForSectionAndName()

#2 /var/www/html/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(361): A17\\Twill\\TwillAppSettings->get()

#3 /var/www/html/vendor/area17/twill/src/Services/Blocks/BladeCompiler.php(32) : eval()'d code(5): Illuminate\\Support\\Facades\\Facade::__callStatic()

#4 /var/www/html/vendor/area17/twill/src/Services/Blocks/BladeCompiler.php(32): eval()

#5 /var/www/html/vendor/area17/twill/src/Services/Blocks/BladeCompiler.php(70): A17\\Twill\\Services\\Blocks\\BladeCompiler::compile()

#6 /var/www/html/vendor/area17/twill/src/Services/Blocks/Block.php(627): A17\\Twill\\Services\\Blocks\\BladeCompiler::render()

#7 /var/www/html/storage/framework/views/fe02b681a008a749db413b7223a6c2db.php(12): A17\\Twill\\Services\\Blocks\\Block->renderForm()

Versions

Twill version: 3.4
Laravel version: 11.9
PHP version: 8.2
Database engine: Mysql 8

[abidkhan484]

Got the reason

It was happening due to access before setup.

There is another block to manage the config where the code A17\Twill\Facades\TwillAppSettings::get('site-settings.hubspot.portal_id') is being used. So, it is being accessed before the value in the AppSettings model.

My solution

I have added the code below to check whether the settings exist in the AppSettings model or not, then called the get method to fetch the settings.

use A17\Twill\Models\AppSetting;
$settingsAvailability = AppSetting::where('name', 'site-settings')->first();
$portalId = $settingsAvailability ? A17\Twill\Facades\TwillAppSettings::get('site-settings.hubspot.portal_id') : "";