Skip to content

Commit 0db1376

Browse files
authored
aregm
1 parent f37623e commit 0db1376

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

docs/gcp.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,5 @@ Note that the proxy is only used by the script itself, it is not used in the clu
6767
6868
# On control node execute
6969
export ICL_INGRESS_DOMAIN={ingress_domain}
70-
# Ray client endpoint is not currently supported on GKE
71-
export ICL_DISABLE_RAY_TEST=1
7270
./scripts/ccn/test.sh
7371
```

terraform/icl/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ module "prefect" {
8585
}
8686

8787
module "ray" {
88+
count = var.ray_enabled ? 1 : 0
8889
source = "../modules/ray"
8990
depends_on = [module.shared-volume]
9091
namespace_labels = var.namespace_labels

terraform/icl/variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,12 @@ variable "prefect_api_url" {
130130
type = string
131131
}
132132

133+
variable "ray_enabled" {
134+
description = "Enable Ray"
135+
type = bool
136+
default = false
137+
}
138+
133139
variable "ray_image" {
134140
description = "Full tag for Ray Docker image"
135141
default = "pbchekin/icl-ray:2.9.2-py39"

tests/smoke/test_ray.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import time
22
from os import getenv
33

4+
import pytest
45
import ray
5-
from pytest import mark
66

77

88
def ray_init(address, retries=10, retry_delay=30):
@@ -25,10 +25,7 @@ def f(x):
2525
return x * x
2626

2727

28-
@mark.skipif(
29-
getenv("ICL_DISABLE_RAY_TEST") is not None,
30-
reason="Ray test is disabled by setting ICL_DISABLE_RAY_TEST",
31-
)
28+
@pytest.mark.skip(reason='Ray disabled')
3229
def test_ray(ray_endpoint):
3330
ray_init(address=f'ray://{ray_endpoint}')
3431
living_nodes = [node for node in ray.nodes() if node.get('alive')]

0 commit comments

Comments
 (0)