aregm
diff --git a/‎.gitignore
-10 b/‎.gitignore
-10
diff --git a/‎.travis.yml
+1-1 b/‎.travis.yml
+1-1
diff --git a/‎CONTRIBUTING.md
+9-9 b/‎CONTRIBUTING.md
+9-9
diff --git a/‎Makefile
+11-4 b/‎Makefile
+11-4
diff --git a/‎README.md
+19-24 b/‎README.md
+19-24
diff --git a/‎common/Makefile
+2-1 b/‎common/Makefile
+2-1
diff --git a/‎common/common.go
+33-19 b/‎common/common.go
+33-19
@@ -1,13 +1,3 @@
 # emacs
 *~
-
-examples/demo
-examples/Firewall
-examples/Forwarding
-examples/dump
-examples/clonable_pcap_dumper
-examples/kni
-examples/copy
-examples/gopacket_parser_example
-test/stash/send_fixed_number
 doc
@@ -35,4 +35,4 @@ script:
   - sudo sh -c 'echo 1024 > /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages'
   - sudo mkdir /mnt/huge
   - sudo mount -t hugetlbfs nodev /mnt/huge
-  - sudo -E env "PATH=$PATH GOROOT=$GOROOT GOPATH=$GOPATH" make testing
+  - sudo -E env "PATH=$PATH GOROOT=$GOROOT GOPATH=$GOPATH" make citesting
@@ -1,10 +1,10 @@
-# Contributing to YANFF
+# Contributing to NFF-GO
 
-YANFF is an open source project licensed under the BSD-style license which can be found in the LICENSE file.
+NFF-GO is an open source project licensed under the BSD-style license which can be found in the LICENSE file.
 
 ## Coding Style
 
-YANFF follows the standard formatting recommendations and language idioms set out
+NFF-GO follows the standard formatting recommendations and language idioms set out
 in the [Effective Go](https://golang.org/doc/effective_go.html) guide. It's
 definitely worth reading - but the relevant sections are
 [formatting](https://golang.org/doc/effective_go.html#formatting)
@@ -34,17 +34,17 @@ Signed-off-by: <[email protected]>
 
 We accept github pull requests.
 
-If you want to work on github.com/intel-go/yanff and your fork on the same workstation you will need to use multiple GOPATHs.  Assuming this is the case
+If you want to work on github.com/intel-go/nff-go and your fork on the same workstation you will need to use multiple GOPATHs.  Assuming this is the case
 
 1. Open a terminal
 2. mkdir -p ~/go-fork/src/github.com/intel-go (replacing go-fork with your preferred location)
 3. export GOPATH=~/go-fork
-4. cd $GOPATH/src/github.com/intel-go/yanff
-5. git clone https://github.com/GITHUB-USERNAME/yanff.git (replace GITHUB-USERNAME with your username)
-6. cd yanff
+4. cd $GOPATH/src/github.com/intel-go/nff-go
+5. git clone https://github.com/GITHUB-USERNAME/nff-go.git (replace GITHUB-USERNAME with your username)
+6. cd nff-go
 7. go install ./...
 
-Once you've finished making your changes push them to your fork and send the PR via the github UI.  If you don't need to maintain the github.com/intel-go/yanff repo and your fork on the same workstation you can skip steps 2 and 3.
+Once you've finished making your changes push them to your fork and send the PR via the github UI.  If you don't need to maintain the github.com/intel-go/nff-go repo and your fork on the same workstation you can skip steps 2 and 3.
 
 ## Quality Controls
 
@@ -56,7 +56,7 @@ We request you give quality assurance some consideration by:
 If you have a problem, please let us know. Write e-mail to [maintainers](mailto:[email protected])
 
 If a bug is not already documented, by all means please [open an
-issue in github](https://github.com/intel-go/YANFF/issues/new) so we all get visibility
+issue in github](https://github.com/intel-go/NFF-GO/issues/new) so we all get visibility
 the problem and work toward resolution.
 
 For feature requests we're also using github issues, with the label
 
@@ -3,13 +3,14 @@
 # license that can be found in the LICENSE file.
 
 PATH_TO_MK = mk
-SUBDIRS = yanff-base dpdk test examples
+SUBDIRS = nff-go-base dpdk test examples
 DOC_TARGETS = flow packet
-TESTING_TARGETS = packet
+CI_TESTING_TARGETS = packet low common
+TESTING_TARGETS = $(CI_TESTING_TARGETS) test/stability
 
 all: $(SUBDIRS)
 
-dpdk: yanff-base
+dpdk: nff-go-base
 
 test: dpdk
 
@@ -19,13 +20,19 @@ perf_testing:
 	$(MAKE) -C test perf_testing
 
 .PHONY: testing $(TESTING_TARGETS)
+.NOTPARALLEL: testing $(TESTING_TARGETS)
 testing: $(TESTING_TARGETS)
+
+.PHONY: citesting $(CI_TESTING_TARGETS)
+.NOTPARALLEL: citesting $(CI_TESTING_TARGETS)
+citesting: $(CI_TESTING_TARGETS)
+
 $(TESTING_TARGETS):
 	$(MAKE) -C $@ testing
 
 .PHONY: doc
 doc: $(DOC_TARGETS)
 	mkdir doc
-	$(foreach package,$(DOC_TARGETS),godoc -analysis=type -analysis=pointer -html github.com/intel-go/yanff/$(package) > doc/$(package).html;)
+	$(foreach package,$(DOC_TARGETS),godoc -analysis=type -analysis=pointer -html github.com/intel-go/nff-go/$(package) > doc/$(package).html;)
 
 include $(PATH_TO_MK)/intermediate.mk
@@ -34,7 +34,7 @@ func CheckFatal(err error) {
 }
 
 func main() {
-	// Initialize NFF-Go library to use 8 cores max.   
+	// Initialize NFF-GO library to use 8 cores max.
 	config := flow.Config{
 		CPUCoresNumber: 8,
 	}
@@ -69,35 +69,32 @@ func L3Separator(currentPacket *packet.Packet, context flow.UserContext) bool {
 	return currentPacket.L3ACLPermit(L3Rules)
 }
 ```
-
-NFF-Go is an Open Source BSD licensed project that runs mostly in Linux user
+NFF-GO is an Open Source BSD licensed project that runs mostly in Linux user
 land. The most recent patches and enhancements provided by the community are
 available in the master branch.
 
-## Getting NFF-Go
-
-Use the **go get** command to download NFF-Go. You must first set your GOPATH
+## Getting NFF-GO
 
+Use the **go get** command to download NFF-GO. You must first set your GOPATH
        export GOPATH=/my/local/directory
        go get -v -d github.com/intel-go/nff-go
 
-Go will download the sources into $GOPATH/src. It will try to build NFF-Go and
+Go will download the sources into $GOPATH/src. It will try to build NFF-GO and
 fail with a message:
 
-        can't load package: package github.com/intel-go/yanff: no buildable Go source files in /localdisk/work/rscohn1/ws/nff-test/src/github.com/intel-go/nff-go
-
+        can't load package: package github.com/intel-go/nff-go: no buildable Go source files in /localdisk/work/rscohn1/ws/nff-go-test/src/github.com/intel-go/nff-go
 Ignore the message for now. We need to install some dependencies before you can
 build.
 
 ### Working with a github fork
 
-If you are working on a fork, then the **go get** command will not put yanff in
+If you are working on a fork, then the **go get** command will not put nff-go in
 $GOPATH/src/github.com/intel-go. However, imports will continue to reference
-githb.com/intel-go. This is a feature of Go and not a problem in the way yanff
+githb.com/intel-go. This is a feature of Go and not a problem in the way nff-go
 is written. See [stackoverflow
 article](https://stackoverflow.com/questions/14323872/using-forked-package-import-in-go)
 for a discussion. A simple way to resolve the problem is to use a symlink. If
-you are rscohn2 on github, and you forked yanff into your personal account,
+you are rscohn2 on github, and you forked nff-go into your personal account,
 then do this:
 
         cd $GOPATH/src/github.com
@@ -109,7 +106,7 @@ then do this:
 
 ### DPDK
 
-NFF-Go uses DPDK, so you must setup your system to build and run DPDK. See [System
+NFF-GO uses DPDK, so you must setup your system to build and run DPDK. See [System
 Requirements in the DPDK Getting Started Guide for
 Linux](http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html) for more
 information.
@@ -142,13 +139,12 @@ Use Go version 1.9 or higher. To check the version of Go, do:
 
         export PATH="$PATH:$GOPATH"/bin
 
-## Building NFF
+## Building NFF-GO
 
         cd $GOPATH/src/github.com/intel-go/nff-go
         make -j8
 
-## Running NFF
-
+# Running NFF-GO
 
 ## Documentation 
 
@@ -167,7 +163,7 @@ and browse the following URLs:
 ## Tests
 
 Invoking make in the top-level directory builds the testing framework and
-examples. NFF-Go distributed tests are packaged inside of Docker container
+examples. NFF-GO distributed tests are packaged inside of Docker container
 images. There are also single node unit tests in some packages that you can
 run using the command:
 
@@ -182,8 +178,8 @@ variable), use the **make images** command.
 To deploy Docker images for use in distributed testing, use the **make deploy**
 command. This command requires two environment variables:
 
-* YANFF_HOSTS="hostname1 hostname2 ... hostnameN"* - a list of all hostnames for deployed test Docker images
-* DOCKER_PORT=2375* - the port number to connect to Docker daemons running on hosts in the YANFF_HOSTS variable
+* NFF_GO_HOSTS="hostname1 hostname2 ... hostnameN"* - a list of all hostnames for deployed test Docker images
+* DOCKER_PORT=2375* - the port number to connect to Docker daemons running on hosts in the NFF_GO_HOSTS variable
 
 To delete generated images in the default Docker target, use the **make
 clean-images** command.
@@ -194,17 +190,17 @@ After the Docker images are deployed on all test hosts, you can run distributed
 network tests. The test framework is located in the test/main directory and
 accepts a JSON file with a test specification. There are predefined configs for
 performance and stability tests in the same directory. To run these tests,
-change **hostname1** and **hostname2** to the hosts from the YANFF_HOSTS list
+change **hostname1** and **hostname2** to the hosts from the NFF_GO_HOSTS list
 in these JSON files.
 
 ## Cleaning-up
 
 To clean all generated binaries, use the **make clean** command.  To delete all
-deployed images listed in YANFF_HOSTS, use the **make cleanall** command.
+deployed images listed in NFF_GO_HOSTS, use the **make cleanall** command.
 
 ## Changing the DPDK sources
 
-If you use the **make** command from NFF-Go directories, the DPDK driver is
+If you use the **make** command from NFF-GO directories, the DPDK driver is
 downloaded automatically.
 
 ## Contributing
@@ -215,7 +211,6 @@ recommend checking the 'janitorial' bugs in our list of open issues; these bugs
 can be solved without an extensive knowledge of NFF-Go. We would love to help
 you start contributing.
 
-You can reach the NFF-Go development team via our [mailing
-list](mailto:[email protected]).
+You can reach the NFF-Go development team via our [mailing list](mailto:[email protected]).
 
 
@@ -9,6 +9,7 @@ include $(PATH_TO_MK)/include.mk
 testing:
 	go test
 
+.PHONY: coverage
 coverage:
 	go test -cover -coverprofile=c.out
-	go tool cover -html=c.out -o common_coverage.html
+	go tool cover -html=c.out -o common_coverage.html
@@ -10,13 +10,16 @@ import (
 	"fmt"
 	"io"
 	"log"
+	"math"
 	"os"
-	"runtime"
 	"strconv"
 
 	"github.com/pkg/errors"
 )
 
+// Max array length for type conversions
+const MaxLength = math.MaxInt32
+
 // Length of addresses.
 const (
 	EtherAddrLen = 6
@@ -128,9 +131,10 @@ const (
 	PcapReadFail
 	PcapWriteFail
 	InvalidCPURangeErr
+	SetAffinityErr
 )
 
-// NFError is error type returned by yanff functions
+// NFError is error type returned by nff-go functions
 type NFError struct {
 	Code     ErrorCode
 	Message  string
@@ -301,7 +305,7 @@ func GetDPDKLogLevel() string {
 	}
 }
 
-// GetDefaultCPUs returns default core list {0, 1, ..., GOMAXPROCS-1}
+// GetDefaultCPUs returns default core list {0, 1, ..., NumCPU}
 func GetDefaultCPUs(cpuNumber uint) []uint {
 	cpus := make([]uint, cpuNumber, cpuNumber)
 	for i := uint(0); i < cpuNumber; i++ {
@@ -310,9 +314,17 @@ func GetDefaultCPUs(cpuNumber uint) []uint {
 	return cpus
 }
 
-// ParseCPUs parses cpu list string into array of cpu numbers
-// and truncate the list according to given coresNumber (GOMAXPROCS)
-func ParseCPUs(s string, coresNumber uint) ([]uint, error) {
+// HandleCPUs parses cpu list string into array of valid core numbers.
+// Removes duplicates
+func HandleCPUList(s string, maxcpu uint) ([]uint, error) {
+	nums, err := parseCPUs(s)
+	nums = removeDuplicates(nums)
+	nums = dropInvalidCPUs(nums, maxcpu)
+	return nums, err
+}
+
+// parseCPUs parses cpu list string into array of cpu numbers
+func parseCPUs(s string) ([]uint, error) {
 	var startRange, k int
 	nums := make([]uint, 0, 256)
 	if s == "" {
@@ -351,19 +363,6 @@ func ParseCPUs(s string, coresNumber uint) ([]uint, error) {
 			j = i + 1
 		}
 	}
-
-	nums = removeDuplicates(nums)
-
-	numCPU := uint(runtime.NumCPU())
-	for _, cpu := range nums {
-		if cpu >= numCPU {
-			return []uint{}, WrapWithNFError(nil, "requested cpu exceeds maximum cores number on machine", MaxCPUExceedErr)
-		}
-	}
-	if len(nums) > int(coresNumber) {
-		return nums[:coresNumber], nil
-	}
-
 	return nums, nil
 }
 
@@ -378,3 +377,18 @@ func removeDuplicates(array []uint) []uint {
 	}
 	return result
 }
+
+// dropInvalidCPUs validates cpu list. Takes array of cpu ids and checks it is < maxcpu on machine,
+// invalid are excluded. Returns list of valid cpu ids.
+func dropInvalidCPUs(nums []uint, maxcpu uint) []uint {
+	i := 0
+	for _, x := range nums {
+		if x < maxcpu {
+			nums[i] = x
+			i++
+		} else {
+			LogWarning(Initialization, "Requested cpu", x, "exceeds maximum cores number on machine, skip it")
+		}
+	}
+	return nums[:i]
+}