Skip to content

Commit 7732cd5

Browse files
committed
chore: prefer string literal over format
1 parent 7e8aadf commit 7732cd5

File tree

3 files changed

+16
-24
lines changed

3 files changed

+16
-24
lines changed

users/filestore.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def get_filestore_token(user_login, host, verify):
4747
data=json.dumps(user_login), verify=verify, timeout=FS_API_TIMEOUT)
4848
r_userlogin.raise_for_status()
4949
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
50-
print("{0}: ".format(err))
50+
print(err)
5151
return None, r_userlogin.status_code
5252
return r_userlogin.text, r_userlogin.status_code
5353

@@ -67,7 +67,7 @@ def add_filestore_auth(user: User):
6767
headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
6868
r_gset.raise_for_status()
6969
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
70-
print("{0}: ".format(err))
70+
print(err)
7171
return False
7272
settings = r_gset.json()
7373
# set new user options
@@ -89,7 +89,7 @@ def add_filestore_auth(user: User):
8989
data=json.dumps(fs_user), headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
9090
r_useradd.raise_for_status()
9191
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
92-
print("{0}: ".format(err))
92+
print(err)
9393
return None
9494

9595
if user.is_staff: # admin and staff get root scope
@@ -116,7 +116,7 @@ def set_filestore_scope(user: User):
116116
headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
117117
r_user.raise_for_status()
118118
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
119-
print("{0}: ".format(err))
119+
print(err)
120120
return False
121121
edit_user = r_user.json()
122122
if user.is_staff: # admin and staff get root scope
@@ -135,7 +135,7 @@ def set_filestore_scope(user: User):
135135
data=json.dumps(fs_user), headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
136136
r_useradd.raise_for_status()
137137
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
138-
print("{0}: ".format(err))
138+
print(err)
139139
return False
140140

141141
fs_user_token, status = use_filestore_auth(user)
@@ -160,7 +160,7 @@ def set_filestore_pass(user: User):
160160
headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
161161
r_users.raise_for_status()
162162
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
163-
print("{0}: ".format(err))
163+
print(err)
164164
return False
165165
print(r_users.text)
166166
for r_user in json.loads(r_users.text):
@@ -180,7 +180,7 @@ def set_filestore_pass(user: User):
180180
data=json.dumps(fs_user), headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
181181
r_useradd.raise_for_status()
182182
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
183-
print("{0}: ".format(err))
183+
print(err)
184184
return None
185185

186186
fs_user_token, status = use_filestore_auth(user)
@@ -208,7 +208,7 @@ def delete_filestore_user(user: User):
208208
headers={"X-Auth": admin_token}, verify=verify, timeout=FS_API_TIMEOUT)
209209
r_user.raise_for_status()
210210
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
211-
print("{0}: ".format(err))
211+
print(err)
212212
return False
213213
del_user = r_user.json()
214214
# remove user scope files
@@ -218,15 +218,15 @@ def delete_filestore_user(user: User):
218218
headers={"X-Auth": fs_user_token}, verify=verify, timeout=FS_API_TIMEOUT)
219219
r_filesdel.raise_for_status()
220220
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
221-
print("{0}: ".format(err))
221+
print(err)
222222
return False
223223
# delete user from filestore db
224224
try:
225225
r_userdel = requests.delete(f"https://{host}/storemng/api/users/{del_user['id']}",
226226
headers={"X-Auth": fs_user_token}, verify=verify, timeout=FS_API_TIMEOUT)
227227
r_userdel.raise_for_status()
228228
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError) as err:
229-
print("{0}: ".format(err))
229+
print(err)
230230
return False
231231

232232
return True

users/persistence.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def _urlopen(url, token, method, verify):
5353
)
5454
return response.text
5555
except (requests.exceptions.ConnectionError, HTTPError) as err:
56-
print("{0}: ".format(err) + url)
56+
print(f"{err}: {url}")
5757
except ValueError as err:
58-
print(f"{response.text} {0}: ".format(err) + url)
58+
print(f"{response.text} {err}: {url}")
5959
return None

users/views.py

+4-12
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,7 @@ def my_scenes(request):
370370
try:
371371
user = get_user_from_id_token(gid_token)
372372
except (ValueError, SocialAccount.DoesNotExist) as err:
373-
return JsonResponse(
374-
{"error": "{0}".format(err)}, status=status.HTTP_403_FORBIDDEN
375-
)
373+
return JsonResponse({"error": err}, status=status.HTTP_403_FORBIDDEN)
376374

377375
serializer = SceneNameSerializer(get_my_scenes(user), many=True)
378376
return JsonResponse(serializer.data, safe=False)
@@ -573,9 +571,7 @@ def user_state(request):
573571
try:
574572
user = get_user_from_id_token(gid_token)
575573
except (ValueError, SocialAccount.DoesNotExist) as err:
576-
return JsonResponse(
577-
{"error": "{0}".format(err)}, status=status.HTTP_403_FORBIDDEN
578-
)
574+
return JsonResponse({"error": err}, status=status.HTTP_403_FORBIDDEN)
579575

580576
if user.is_authenticated:
581577
if user.username.startswith("admin"):
@@ -613,9 +609,7 @@ def storelogin(request):
613609
try:
614610
user = get_user_from_id_token(gid_token)
615611
except (ValueError, SocialAccount.DoesNotExist) as err:
616-
return JsonResponse(
617-
{"error": "{0}".format(err)}, status=status.HTTP_403_FORBIDDEN
618-
)
612+
return JsonResponse({"error": err}, status=status.HTTP_403_FORBIDDEN)
619613

620614
fs_user_token = None
621615
if user.is_authenticated:
@@ -749,9 +743,7 @@ def arena_token(request):
749743
try:
750744
user = get_user_from_id_token(gid_token)
751745
except (ValueError, SocialAccount.DoesNotExist) as err:
752-
return JsonResponse(
753-
{"error": "{0}".format(err)}, status=status.HTTP_403_FORBIDDEN
754-
)
746+
return JsonResponse({"error": err}, status=status.HTTP_403_FORBIDDEN)
755747

756748
if user.is_authenticated:
757749
username = user.username

0 commit comments

Comments
 (0)