Skip to content

Commit 9e1e9c1

Browse files
committed
n64: disable RDP readbacks from super-sampled image
This fixes some tests in the official RDP testsuite
1 parent d942746 commit 9e1e9c1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: ares/n64/vulkan/vulkan.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,10 @@ Vulkan::Implementation::Implementation(u8* data, u32 size) {
235235

236236
if(vulkan.internalUpscale > 1) {
237237
flags |= ::RDP::COMMAND_PROCESSOR_FLAG_SUPER_SAMPLED_DITHER_BIT;
238-
flags |= ::RDP::COMMAND_PROCESSOR_FLAG_SUPER_SAMPLED_READ_BACK_BIT;
238+
//rasky: this is explicitly disabled because we want to make sure we don't
239+
// read back the super sampled version, as it can cause artifacts. We want
240+
// parallelRDP to also produce a 1x render to use for readbacks.
241+
//flags |= ::RDP::COMMAND_PROCESSOR_FLAG_SUPER_SAMPLED_READ_BACK_BIT;
239242
}
240243

241244
processor = new ::RDP::CommandProcessor(device, data, 0, size, size / 2, flags);

0 commit comments

Comments
 (0)