[SNES] Possible issue with auto joypad polling

[Max833]

Describe the bug / Steps to reproduce the behavior:

When you are in a soccer game in "Zenkoku Koukou Soccer 2 (Japan)" and want to pause the game with "start", you will notice that it can't be accessed safely without it closing immediately. Some time ago there was a game that had a very similar issue and was later fixed:

SpellCraft - Aspects of Valor , bsnes-emu/bsnes@4f7a269

[remutro]

Note: The commit referenced here: bsnes-emu/bsnes@39c37ec
already exists in ares.

[Max833]

Yes, bsnes has the exact same issue and Spellcraft is working in both emulators, but something is not 100% right yet.

[FitzRoyX]

If you tap it quickly enough it does stay paused, however snes9x you can press and hold and it will stay paused. Can anyone check hardware with a flash cart to verify it's not just bad programming on the game's part?

[Max833]

Mesen improved auto-read emulation. There is a new test rom as well. Maybe this is helpful. You can read a lot more about this topic in the "SNES development" discord server.

Mesen changes
SourMesen/Mesen2@efcf0d1

Source
https://github.com/undisbeliever/snes-test-roms/blob/master/src/hardware-tests/auto-joy-timing-test.asm

ROM
auto-joy-timing-test.zip

[FitzRoyX]

The test rom is not pass/fail, so we have no idea what min/max results are on a real snes unless someone here tests it

ares

mesen2

snes9x

[Morilli]

According to what's been posted on the discord, the expected console values are

	cur	min	max
start	-	002A/002C	0070
end	-	004B/004C	009C/009B

which seems to match mesen2's results.

[Max833]

Mesen improved auto-read emulation. There is a new test rom as well. Maybe this is helpful. You can read a lot more about this topic:

//This is based on these test roms: https://github.com/undisbeliever/snes-test-roms/blob/master/src/hardware-tests/
//As well as the CPU schematics here: https://github.com/rgalland/SNES_S-CPU_Schematics/

SourMesen/Mesen2@d1aa957#diff-e6a252584eeb754a8d86aced8463d5b12c223f99d5bf8213d3dcfa78655fa077R64

SourMesen/Mesen2@e4d3176

And:

SourMesen/Mesen2@6b77200

[Max833]

bsnes fixed all auto-joypad polling timing as well. =) Maybe ares can port these changes as well?

bsnes-emu/bsnes#351
bsnes-emu/bsnes#322

[Max833]

bsnes fixed all auto-joypad polling timing as well. =) Maybe ares can port these changes as well?

bsnes-emu/bsnes#351 bsnes-emu/bsnes#322

@Morilli: Do you think it is possible that you fix these bugs in ares as well? It would be really appreciated. Or at least getting permission to relicense the commit to ISC for ares...