fix: player can click on screen after destroyed

Author: SohKey

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 .env
+data
 types

src/player/menu.js

@@ -1,4 +1,4 @@
-import { destroy_inventory, display_menu, Menus } from '../player_menu.js'
+import { destroy_menu, display_menu, Menus } from '../player_menu.js'
 import freeze_player from '../freeze_player.js'
 import { SCREENS } from '../settings.js'
 import { Context } from '../events.js'
@@ -31,7 +31,7 @@ export default {
         })
 
         events.on(Context.SCREEN_INTERRACT, payload => {
-          const { x, y } = payload
+          const { x, y, screen_id } = payload
 
           const click_position = {
             x,
@@ -50,6 +50,7 @@ export default {
           }
 
           console.log('position:', click_position)
+          console.log('screen:', screen_id)
 
           if (is_inside(interactables.stats, click_position)) {
             display_menu({
@@ -77,7 +78,7 @@ export default {
     const screenids = [SCREENS.player_screen, SCREENS.clone_background]
     client.on('steer_vehicle', ({ jump }) => {
       if (jump === 0x2) {
-        destroy_inventory(client, world, entityids, screenids)
+        destroy_menu(client, world, entityids, screenids)
       }
     })
 

src/player/screen.js

@@ -14,6 +14,10 @@ const mcData = minecraftData(VERSION)
 const { nearestMatch } = mapcolors
 const { createCanvas } = canvas
 
+const SPAWNED_SCREENS = {
+  screens: [],
+}
+
 export function register_screen({ id, size: { width, height } }) {
   return world => ({
     ...world,
@@ -106,6 +110,8 @@ export function spawn_screen(
       })
     }
   }
+
+  SPAWNED_SCREENS.screens[SPAWNED_SCREENS.screens.length] = screen_id
 }
 
 export function update_screen(
@@ -154,12 +160,15 @@ export function update_screen(
 
 export function destroy_screen({ client, world }, { screen_id }) {
   const { size, start_id } = world.screens[screen_id]
-
   client.write('entity_destroy', {
     entityIds: Array.from({
       length: size.width * size.height,
     }).map((v, index) => start_id + index),
   })
+
+  SPAWNED_SCREENS.screens = SPAWNED_SCREENS.screens.filter(
+    id => id !== screen_id
+  )
 }
 
 export function copy_canvas(old_canvas) {
@@ -214,7 +223,7 @@ export default {
         const { position } = state
         for (const [screen_id, screen] of Object.entries(world.screens)) {
           const intersect = screen_ray_intersection(screen, position)
-          if (intersect) {
+          if (intersect && SPAWNED_SCREENS.screens.includes(screen_id)) {
             const { x, y } = intersect
             events.emit(Context.SCREEN_INTERRACT, {
               x,

src/player_menu.js

@@ -111,7 +111,7 @@ export async function display_menu({
   }
 }
 
-export function destroy_inventory(client, world, entityIds, screenIds) {
+export function destroy_menu(client, world, entityIds, screenIds) {
   client.write('entity_destroy', {
     entityIds,
   })