Merge pull request #134 from argentlabs/fix/connect-injected-wallet

fix: add params to connect method and update starknetkit modal to use…

Author: bluecco

src/connectors/connector.ts

@@ -28,6 +28,10 @@ export interface ConnectorEvents {
   disconnect(): void
 }
 
+export type ConnectOptions = {
+  silent_mode: boolean
+}
+
 export abstract class Connector extends EventEmitter<ConnectorEvents> {
   /** Unique connector id. */
   abstract get id(): string
@@ -41,7 +45,7 @@ export abstract class Connector extends EventEmitter<ConnectorEvents> {
   /** Whether connector is already authorized */
   abstract ready(): Promise<boolean>
   /** Connect wallet. */
-  abstract connect(): Promise<ConnectorData>
+  abstract connect(params?: ConnectOptions): Promise<ConnectorData>
   /** Disconnect wallet. */
   abstract disconnect(): Promise<void>
   /** Get current account silently. Return null if the account is not authorized */

src/connectors/injected/index.ts

@@ -18,6 +18,7 @@ import {
 } from "../../errors"
 import { removeStarknetLastConnectedWallet } from "../../helpers/lastConnected"
 import {
+  ConnectOptions,
   Connector,
   type ConnectorData,
   type ConnectorIcons,
@@ -138,7 +139,7 @@ export class InjectedConnector extends Connector {
     return new Account(provider, accounts[0], "")
   }
 
-  async connect(): Promise<ConnectorData> {
+  async connect(params: ConnectOptions): Promise<ConnectorData> {
     this.ensureWallet()
 
     if (!this._wallet) {
@@ -147,9 +148,16 @@ export class InjectedConnector extends Connector {
 
     let accounts: string[]
     try {
-      accounts = await this.request({
-        type: "wallet_requestAccounts",
-      })
+      accounts = await this.request(
+        params
+          ? {
+              type: "wallet_requestAccounts",
+              params,
+            }
+          : {
+              type: "wallet_requestAccounts",
+            },
+      )
     } catch {
       throw new UserRejectedRequestError()
     }

src/main.ts

@@ -52,7 +52,9 @@ export const connect = async ({
       let connectorData: ConnectorData | null = null
 
       if (connector && resultType === "wallet") {
-        connectorData = await connector.connect()
+        connectorData = await connector.connect({
+          silent_mode: true,
+        })
       }
 
       return {