Merge pull request #206 from argentlabs/fix/connect-silent-ax

fix: connectSilent method for injected connector

Author: bluecco

.github/workflows/release.yml

@@ -7,6 +7,7 @@ on:
       - beta-braavos-mobile
       - beta-argent-ww-iframe
       - beta-wallet-account
+      - beta-connect-silent
       - hotfix\/v[0-9]+.[0-9]+.[0-9]+
 
 jobs:

.releaserc

@@ -16,6 +16,10 @@
     {
       "name": "beta-argent-ww-iframe",
       "prerelease": true
+    },
+    {
+      "name": "beta-connect-silent",
+      "prerelease": true
     }
   ],
   "plugins": [

src/connectors/connector.ts

@@ -1,7 +1,7 @@
 import EventEmitter from "eventemitter3"
 import {
-  AccountInterface,
-  ProviderInterface,
+  type AccountInterface,
+  type ProviderInterface,
   type ProviderOptions,
 } from "starknet"
 import type {
@@ -34,6 +34,7 @@ export interface ConnectorEvents {
 
 export type ConnectArgs = {
   chainIdHint?: bigint
+  silent_mode?: boolean
 }
 
 export abstract class Connector extends EventEmitter<ConnectorEvents> {

src/connectors/injected/index.ts

@@ -158,6 +158,7 @@ export class InjectedConnector extends Connector {
     try {
       accounts = await this.request({
         type: "wallet_requestAccounts",
+        params: { silent_mode: _args.silent_mode },
       })
     } catch {
       throw new UserRejectedRequestError()

src/main.ts

@@ -2,8 +2,8 @@ import type { DisconnectOptions } from "@starknet-io/get-starknet"
 import sn from "@starknet-io/get-starknet-core"
 import type { StarknetWindowObject } from "@starknet-io/types-js"
 import {
-  Connector,
-  StarknetkitConnector,
+  type Connector,
+  type StarknetkitConnector,
   type ConnectorData,
 } from "./connectors"
 import { DEFAULT_WEBWALLET_URL } from "./connectors/webwallet/constants"
@@ -83,7 +83,10 @@ export const connect = async ({
       let connectorData: ConnectorData | null = null
 
       if (connector && resultType === "wallet") {
-        connectorData = await connector.connect()
+        // Only ArgentX connector will use silent_mode param to avoid breaking changes on other wallets
+        connectorData = await connector.connect({
+          silent_mode: connector.id === "argentX",
+        })
       }
 
       return {
@@ -115,7 +118,11 @@ export const connect = async ({
       let connectorData: ConnectorData | null = null
 
       if (resultType === "wallet") {
-        connectorData = (await connector?.connect()) ?? null
+        // Only ArgentX connector will use silent_mode param to avoid breaking changes on other wallets
+        connectorData =
+          (await connector?.connect({
+            silent_mode: connector.id === "argentX",
+          })) ?? null
       }
 
       if (connector) {