Merge pull request #36 from argentlabs/refactor/session-pk

refactor: update session pk type

Author: vladutjs

README.md

@@ -60,14 +60,15 @@ import {
   SignSessionError,
   CreateSessionParams,
   createSession,
-  buildSessionAccount
+  buildSessionAccount,
+  bytesToHexString
 } from "@argent/x-sessions"
 import { ec } from "starknet"
 
 const privateKey = ec.starkCurve.utils.randomPrivateKey()
 
 const sessionKey: SessionKey = {
-  privateKey,
+  privateKey: bytesToHexString(privateKey),
   publicKey: ec.starkCurve.getStarkKey(privateKey)
 }
 
@@ -150,7 +151,7 @@ This package expose a method in order to get the Call required to perform an exe
 const privateKey = ec.starkCurve.utils.randomPrivateKey()
 
 const sessionKey: SessionKey = {
-  privateKey,
+  privateKey: bytesToHexString(privateKey),
   publicKey: ec.starkCurve.getStarkKey(privateKey)
 }
 

src/outsideExecution.ts

@@ -144,7 +144,7 @@ export const createOutsideExecutionCall = async ({
   const outsideExecutionTypedData = buildOutsideExecutionTypedData({
     outsideExecution,
     chainId: session.chainId,
-    version: version || "1",
+    version: version || "2", // version, set as "2" because of a bug in x-sessions where default was wrongly set to "1"
   })
 
   const signature = await signOutsideExecution({

src/session.types.ts

@@ -69,7 +69,7 @@ export type CreateSessionParams = {
 
 export type SessionKey = {
   publicKey: string
-  privateKey: Uint8Array
+  privateKey: string
 }
 
 export type BuildSessionAccountParams = {

src/utils.ts

@@ -3,6 +3,7 @@ import {
   Account,
   constants,
   ec,
+  encode,
   hash,
   shortString,
   Signature,
@@ -238,6 +239,29 @@ const verifySession = ({
   )
 }
 
+/**
+ * Converts a byte array to a hex string.
+ * @param bytes The byte array to convert.
+ * @returns The hex string.
+ */
+const bytesToHexString = (bytes: Uint8Array): string => {
+  return encode.addHexPrefix(encode.buf2hex(bytes))
+}
+
+/**
+ * Converts a hex string to a byte array.
+ * @param hexString The hex string to convert.
+ * @returns The byte array.
+ */
+const hexStringToBytes = (hexString: string): Uint8Array => {
+  const hex = encode.removeHexPrefix(hexString)
+  const hexArray = hex.match(/.{1,2}/g)
+  if (!hexArray) {
+    throw new Error("Invalid hex string")
+  }
+  return Uint8Array.from(hexArray.map((byte) => parseInt(byte, 16)))
+}
+
 export {
   buildSessionAccount,
   createOffchainSession,
@@ -247,4 +271,6 @@ export {
   getSessionTypedData,
   sessionTypes,
   verifySession,
+  bytesToHexString,
+  hexStringToBytes,
 }