Skip to content

Commit 6b2de97

Browse files
committed
fix invalid ip address error
Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
1 parent 7bc183b commit 6b2de97

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

hack/dev-env/create-agent-config.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,12 @@ if test "${ARGOCD_AGENT_IN_CLUSTER}" = ""; then
3838
ARGOCD_AGENT_RESOURCE_PROXY_SAN="--ip 127.0.0.1,${IPADDR}"
3939
else
4040
ARGOCD_AGENT_GRPC_SVC=$(getExternalLoadBalancerIP ${ARGOCD_AGENT_PRINCIPAL_CONTEXT} ${ARGOCD_PRINCIPAL_NAMESPACE} argocd-agent-principal)
41-
ARGOCD_AGENT_GRPC_SAN="--ip 127.0.0.1,$ARGOCD_AGENT_GRPC_SVC"
41+
# OpenShift/AWS LoadBalancers often expose a hostname instead of an IP.
42+
if [[ "$ARGOCD_AGENT_GRPC_SVC" =~ ^([0-9]{1,3}\.){3}[0-9]{1,3}$ ]]; then
43+
ARGOCD_AGENT_GRPC_SAN="--ip 127.0.0.1,${ARGOCD_AGENT_GRPC_SVC}"
44+
else
45+
ARGOCD_AGENT_GRPC_SAN="--ip 127.0.0.1 --dns ${ARGOCD_AGENT_GRPC_SVC}"
46+
fi
4247
ARGOCD_AGENT_RESOURCE_PROXY=argocd-agent-resource-proxy
4348
ARGOCD_AGENT_RESOURCE_PROXY_SAN="--dns ${ARGOCD_AGENT_RESOURCE_PROXY}"
4449
fi

0 commit comments

Comments
 (0)