add support to override redis image, add support to create argocd-secret with key server.secretKey

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>

Author: anandrkskd

install/helm-repo/argocd-agent-agent/templates/NOTES.txt

@@ -46,4 +46,8 @@ Configuration overview
 Bundled Argo CD
 ---------------
 This release includes the argo-cd subchart. Configure it under the `argocd` values key. Upgrades and rollbacks apply to the agent and Argo CD together.
+
+The argocd-secret is managed by this chart with an auto-generated
+server.secretkey. The key is preserved across upgrades. To set your own:
+  --set argocd.configs.secret.extra.server\.secretkey=YOUR-KEY
 {{- end }}

install/helm-repo/argocd-agent-agent/templates/argocd-secret.yaml

@@ -0,0 +1,37 @@
+{{- if .Values.argoCD.enabled }}
+{{- $ns := include "argo-cd.namespace" . }}
+{{- $secretName := "argocd-secret" }}
+{{- $extra := .Values.argocd.configs.secret.extra | default dict }}
+{{- $explicitKey := index $extra "server.secretkey" | default "" }}
+{{- $serverSecretKey := "" }}
+{{- if $explicitKey }}
+  {{- $serverSecretKey = $explicitKey }}
+{{- else }}
+  {{- $existingSecret := lookup "v1" "Secret" $ns $secretName }}
+  {{- if and $existingSecret $existingSecret.data }}
+    {{- $encodedKey := index $existingSecret.data "server.secretkey" }}
+    {{- if $encodedKey }}
+      {{- $serverSecretKey = $encodedKey | b64dec }}
+    {{- end }}
+  {{- end }}
+  {{- if not $serverSecretKey }}
+    {{- $serverSecretKey = randAlphaNum 20 }}
+  {{- end }}
+{{- end }}
+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ $secretName }}
+  namespace: {{ $ns }}
+  labels:
+    {{- include "argocd-agent-agent.labels" . | nindent 4 }}
+    app.kubernetes.io/component: argocd-secret
+type: Opaque
+data:
+  server.secretkey: {{ $serverSecretKey | b64enc }}
+  {{- range $key, $value := $extra }}
+  {{- if ne $key "server.secretkey" }}
+  {{ $key }}: {{ $value | b64enc }}
+  {{- end }}
+  {{- end }}
+{{- end }}

install/helm-repo/argocd-agent-agent/values.yaml

@@ -30,14 +30,22 @@ argocd:
   # -- Disable the Argo CD notifications controller (`notifications.enabled` in argo-helm).
   notifications:
     enabled: false
+  redis:
+    image:
+      # -- Redis image repository (change for a private or custom registry mirror).
+      repository: ecr-public.aws.com/docker/library/redis
+      # -- Redis image tag.
+      tag: 8.2.3-alpine
+  repoServer:
+    copyutil:
+      # -- Clear default copyutil extra args to avoid issues when repo-server is bundled.
+      extraArgs: ""
   configs:
     secret:
-      # -- Seed the Argo CD server secret key so the application controller can
-      # decrypt cluster credentials even when the Argo CD server is not running
-      # (server.replicas=0). Override with a stable random value in production;
-      # the default is intentionally non-empty so the chart works out of the box.
-      extra:
-        server.secretkey: "CHANGE-ME-generate-a-random-secret-key"
+      # -- Disable subchart's argocd-secret creation; the parent chart manages
+      # it with an auto-generated server.secretkey (see templates/argocd-secret.yaml).
+      createSecret: false
+      extra: {}
 
 ## @section Global
 # -- (Deprecated: use global.namespaceOverride) Override namespace for the agent chart only.