Better organize metric names

[gnunn1]

Is your feature request related to a problem? Please describe.

The documentation for the Argo CD Agent show a number of metrics available. However these metrics are named independently using "principal_" or "agent_" as prefixes with no clear relationship with Argo CD or the Argo CD Agent. When browsing metrics in dashboard tools like Grafana, Perseus or the OpenShift Console it can make it challenging for users to find the correct metric.

Describe the solution you'd like

I would like to see the metrics prefixed with "argocd_", this would align with how Argo CD handles metrics and would make it clear where these metrics are being sourced from.

Current metrics are currently prefixed with either "principal_" or "agent_" so adding "argocd_" in front of that prefix would work fine as it results in logical "argocd_principal_" and "argocd_agent_" prefixes.

Describe alternatives you've considered

None

Additional context

Documentation on Argo CD metrics is here: https://argocd-agent.readthedocs.io/latest/operations/metrics/

[jgwest]

@jparsai want to take a look at this one as well, since you are already looking into metrics for the dashboard?

[jannfis]

As I'm currently working on metrics, I take this one.

[jparsai]

I will wait for this change to be done, before raising PR for #904

[jannfis]

I was wondering if we should give up the "agent" and "principal" distinctions for many of the metrics. Probably quite a few of them are applicable in both the principal, and the agent.

So in terms of dashboards, would it make sense to use the same metric name across the principal and agents for most things? So the same dashboard could be used for the principal and the agents?