chore: update field comment on ArgoCDSpec cmdParams (#2146)

jgwest · web-flow · commit 3e8a1329b60b · 2026-04-07T11:41:19.000+02:00
Signed-off-by: Jonathan West &lt;jgwest@gmail.com&gt;
diff --git a/api/v1beta1/argocd_types.go b/api/v1beta1/argocd_types.go
@@ -1054,6 +1054,8 @@ type ArgoCDSpec struct {
 	AggregatedClusterRoles bool `json:"aggregatedClusterRoles,omitempty"`
 
 	// CmdParams specifies command-line parameters for the Argo CD components.
+	// The only keys currently supported for this parameter are:
+	// - controller.resource.health.persist
 	CmdParams map[string]string `json:"cmdParams,omitempty"`
 
 	// ArgoCDAgent defines configurations for the ArgoCD Agent component.
diff --git a/bundle/manifests/argoproj.io_argocds.yaml b/bundle/manifests/argoproj.io_argocds.yaml
@@ -11948,8 +11948,10 @@ spec:
               cmdParams:
                 additionalProperties:
                   type: string
-                description: CmdParams specifies command-line parameters for the Argo
-                  CD components.
+                description: |-
+                  CmdParams specifies command-line parameters for the Argo CD components.
+                  The only keys currently supported for this parameter are:
+                  - controller.resource.health.persist
                 type: object
               configManagementPlugins:
                 description: 'Deprecated: ConfigManagementPlugins field is no longer
diff --git a/config/crd/bases/argoproj.io_argocds.yaml b/config/crd/bases/argoproj.io_argocds.yaml
@@ -11937,8 +11937,10 @@ spec:
               cmdParams:
                 additionalProperties:
                   type: string
-                description: CmdParams specifies command-line parameters for the Argo
-                  CD components.
+                description: |-
+                  CmdParams specifies command-line parameters for the Argo CD components.
+                  The only keys currently supported for this parameter are:
+                  - controller.resource.health.persist
                 type: object
               configManagementPlugins:
                 description: 'Deprecated: ConfigManagementPlugins field is no longer
diff --git a/controllers/argocd/configmap.go b/controllers/argocd/configmap.go
@@ -939,6 +939,7 @@ func (r *ReconcileArgoCD) reconcileGPGKeysConfigMap(cr *argoproj.ArgoCD) error {
 }
 
 // reconcileArgoCmdParamsConfigMap will ensure that the ConfigMap containing command line parameters for ArgoCD is present.
+// - NOTE: When updating this function (for example, adding a new supported field), update the method comment in argocd_types.go for the 'CmdParams' field of ArgoCDSpec.
 func (r *ReconcileArgoCD) reconcileArgoCmdParamsConfigMap(cr *argoproj.ArgoCD) error {
 	cm := newConfigMapWithName(common.ArgoCDCmdParamsConfigMapName, cr)
 	cm.Data = make(map[string]string)
diff --git a/deploy/olm-catalog/argocd-operator/0.19.0/argoproj.io_argocds.yaml b/deploy/olm-catalog/argocd-operator/0.19.0/argoproj.io_argocds.yaml
@@ -11948,8 +11948,10 @@ spec:
               cmdParams:
                 additionalProperties:
                   type: string
-                description: CmdParams specifies command-line parameters for the Argo
-                  CD components.
+                description: |-
+                  CmdParams specifies command-line parameters for the Argo CD components.
+                  The only keys currently supported for this parameter are:
+                  - controller.resource.health.persist
                 type: object
               configManagementPlugins:
                 description: 'Deprecated: ConfigManagementPlugins field is no longer

Original file line number	Diff line number	Diff line change
`@@ -939,6 +939,7 @@ func (r ReconcileArgoCD) reconcileGPGKeysConfigMap(cr argoproj.ArgoCD) error {`
`939`	`939`	`}`
`940`	`940`
`941`	`941`	`// reconcileArgoCmdParamsConfigMap will ensure that the ConfigMap containing command line parameters for ArgoCD is present.`
	`942`	`+// - NOTE: When updating this function (for example, adding a new supported field), update the method comment in argocd_types.go for the 'CmdParams' field of ArgoCDSpec.`
`942`	`943`	`func (r ReconcileArgoCD) reconcileArgoCmdParamsConfigMap(cr argoproj.ArgoCD) error {`
`943`	`944`	`cm := newConfigMapWithName(common.ArgoCDCmdParamsConfigMapName, cr)`
`944`	`945`	`cm.Data = make(map[string]string)`