Skip to content

Commit 54985bd

Browse files
committed
fix: Make Renewal Token Expiry Feature Configurable
Signed-off-by: akhil nittala <nakhil@redhat.com>
1 parent 91e627d commit 54985bd

1 file changed

Lines changed: 27 additions & 2 deletions

File tree

controllers/argocd/secret.go

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -923,8 +923,14 @@ func (r *ReconcileArgoCD) reconcileSecrets(cr *argoproj.ArgoCD) error {
923923
return err
924924
}
925925

926-
if err := r.reconcileDexLegacySATokenSecrets(cr); err != nil {
927-
return err
926+
if isDexTokenExpiryFeatureEnabled(cr) {
927+
if err := r.reconcileDexLegacySATokenSecrets(cr); err != nil {
928+
return err
929+
}
930+
} else {
931+
if err := r.reconcileDexTokenRequestSecret(cr); err != nil {
932+
return err
933+
}
928934
}
929935

930936
if err := r.reconcileArgoSecret(cr); err != nil {
@@ -934,6 +940,25 @@ func (r *ReconcileArgoCD) reconcileSecrets(cr *argoproj.ArgoCD) error {
934940
return nil
935941
}
936942

943+
func (r *ReconcileArgoCD) reconcileDexTokenRequestSecret(cr *argoproj.ArgoCD) error {
944+
secret := argoutil.NewSecretWithSuffix(cr, common.ArgoCDDefaultDexServiceAccountName+"-token")
945+
946+
err := r.Client.Get(context.TODO(), client.ObjectKey{Namespace: cr.Namespace, Name: secret.Name}, secret)
947+
if apierrors.IsNotFound(err) {
948+
return nil
949+
}
950+
if err != nil {
951+
return err
952+
}
953+
954+
if secret.Type != corev1.SecretTypeOpaque {
955+
return nil
956+
}
957+
958+
argoutil.LogResourceDeletion(log, secret, "removing TokenRequest token secret")
959+
return r.Delete(context.TODO(), secret)
960+
}
961+
937962
func (r *ReconcileArgoCD) getClusterSecrets(cr *argoproj.ArgoCD) (*corev1.SecretList, error) {
938963

939964
clusterSecrets := &corev1.SecretList{}

0 commit comments

Comments
 (0)