fix: correct total counter

Author: alexec

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## v0.0.43 (2021-06-08)
+
+ * [a03615d](https://github.com/argoproj/argo-workflows/commit/a03615d7ccd5d7ed68479cdebff76b0ce5e05a17) ok
+
+### Contributors
+
+ * Alex Collins
+
 ## v0.0.42 (2021-06-08)
 
  * [d2f219f](https://github.com/argoproj/argo-workflows/commit/d2f219f806277636ab5b4c41dd26ea87c887ec3a) ok

runner/sidecar/sidecar.go

@@ -341,6 +341,9 @@ func connectSources(ctx context.Context, toMain func([]byte) error) error {
 		retryPolicy := source.RetryPolicy
 		f := func(msg []byte) error {
 			rateCounter.Incr(1)
+			withLock(func() {
+				step.Status.SourceStatuses.IncrTotal(sourceName, replica, printable(msg), rateToResourceQuantity(rateCounter))
+			})
 			err := wait.ExponentialBackoff(wait.Backoff{
 				Duration: 100 * time.Millisecond,
 				Factor:   1.2,
@@ -365,10 +368,6 @@ func connectSources(ctx context.Context, toMain func([]byte) error) error {
 				}
 			})
 			if err != nil {
-				withLock(func() {
-					step.Status.SourceStatuses.IncrTotal(sourceName, replica, printable(msg), rateToResourceQuantity(rateCounter))
-				})
-			} else {
 				withLock(func() { step.Status.SourceStatuses.IncrErrors(sourceName, replica, err) })
 			}
 			return err